[perl #41819] [PATCH */2]: [t/pmc] minor object-meths.t clean-ups

0 views
Skip to first unread message

Sam Vilain

unread,
Mar 13, 2007, 9:52:42 PM3/13/07
to bugs-bi...@rt.perl.org
# New Ticket Created by Sam Vilain
# Please include the string: [perl #41819]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=41819 >


Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: binary
MIME-Version: 1.0
X-Mailer: MIME-tools 5.419 (Entity 5.419)

This is a combined patch submission which I made by munging the output
of `git-format-patch HEAD~2` on my branch samv/object-meths.

The patches are:

- [t/pmc] de-number some tests in object-meths.t
t/pmc/object-meths.t | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

- [t/pmc] remove duplicate test in object-meths.t
t/pmc/object-meths.t | 33 ---------------------------------
1 files changed, 0 insertions(+), 33 deletions(-)

Content-Type: text/x-patch;
name="t-pmc-de-number-some-tests-in-object-meths.t.patch"
Content-Disposition: inline;
filename="t-pmc-de-number-some-tests-in-object-meths.t.patch"
Content-Transfer-Encoding: binary
Content-Description: [PATCH] [t/pmc] de-number some tests in object-meths.t
MIME-Version: 1.0
X-Mailer: MIME-tools 5.419 (Entity 5.419)

[t/pmc] de-number some tests in object-meths.t

It was getting silly renumbering them, move to descriptive names
---
t/pmc/object-meths.t | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/t/pmc/object-meths.t b/t/pmc/object-meths.t
index 0dc7f08..b1da69a 100644
--- a/t/pmc/object-meths.t
+++ b/t/pmc/object-meths.t
@@ -942,7 +942,7 @@ CODE
foofoo
OUTPUT

-pir_output_is( <<'CODE', <<'OUTPUT', "super 1 - two classes" );
+pir_output_is( <<'CODE', <<'OUTPUT', ".Super - test dispatch with two classes" );
.sub main :main
.local pmc o, cl
cl = newclass 'Parent'
@@ -975,7 +975,7 @@ OUTPUT

TODO: {
local $TODO = "3 class interitance, 4-class diamond inheritance";
-pir_output_is( <<'CODE', <<'OUTPUT', "super 2 - test dispatch" );
+pir_output_is( <<'CODE', <<'OUTPUT', ".Super - dispatch on addparent-established heirarchy" );
.sub main :main
.local pmc o, cl, cl2
cl = newclass 'Parent'
@@ -1008,7 +1008,7 @@ Parent foo
Parent bar
OUTPUT

-pir_output_is( <<'CODE', <<'OUTPUT', "super 3 - two classes, addparent" );
+pir_output_is( <<'CODE', <<'OUTPUT', ".Super - dispatch on addparent-established heirarchy" );
.sub main :main
.local pmc o, p, c
p = newclass 'Parent'
@@ -1040,7 +1040,7 @@ Parent foo
Parent bar
OUTPUT

-pir_output_is( <<'CODE', <<'OUTPUT', "super 4 - three classes" );
+pir_output_is( <<'CODE', <<'OUTPUT', ".Super - subclass established, three levels deep" );
.sub main :main
.local pmc o, p, c, g
p = newclass 'Parent'
@@ -1078,7 +1078,7 @@ Child foo
Parent foo
OUTPUT

-pir_output_is( <<'CODE', <<'OUTPUT', "super 5 - diamond" );
+pir_output_is( <<'CODE', <<'OUTPUT', ".Super - simple 4-class diamond C3 dispatch" );
.sub main :main
.local pmc o, p, c1, c2, i
p = newclass 'Parent'
--
1.5.0.2.21.gdcde2

Content-Type: text/x-patch;
name="t-pmc-remove-duplicate-test-in-object-meths.t.patch"
Content-Disposition: inline;
filename="t-pmc-remove-duplicate-test-in-object-meths.t.patch"
Content-Transfer-Encoding: binary
Content-Description: [PATCH] [t/pmc] remove duplicate test in object-meths.t
MIME-Version: 1.0
X-Mailer: MIME-tools 5.419 (Entity 5.419)

[t/pmc] remove duplicate test in object-meths.t

r17031 added two tests that are the same, remove the second one.
---
t/pmc/object-meths.t | 33 ---------------------------------
1 files changed, 0 insertions(+), 33 deletions(-)

diff --git a/t/pmc/object-meths.t b/t/pmc/object-meths.t
index b1da69a..37631b9 100644
--- a/t/pmc/object-meths.t
+++ b/t/pmc/object-meths.t
@@ -977,39 +977,6 @@ TODO: {
local $TODO = "3 class interitance, 4-class diamond inheritance";
pir_output_is( <<'CODE', <<'OUTPUT', ".Super - dispatch on addparent-established heirarchy" );
.sub main :main
- .local pmc o, cl, cl2
- cl = newclass 'Parent'
- #cl = subclass cl, 'Child'
- cl2 = newclass 'Child'
- addparent cl2, cl
- o = new 'Child'
- o."foo"()
-.end
-
-.namespace ['Parent']
-.sub foo :method
- print "Parent foo\n"
- self."bar"()
-.end
-.sub bar :method
- print "Parent bar\n"
-.end
-
-.namespace ['Child']
-.sub foo :method
- print "Child foo\n"
- .local pmc s
- s = new .Super, self
- s."foo"()
-.end
-CODE
-Child foo
-Parent foo
-Parent bar
-OUTPUT
-
-pir_output_is( <<'CODE', <<'OUTPUT', ".Super - dispatch on addparent-established heirarchy" );
-.sub main :main
.local pmc o, p, c
p = newclass 'Parent'
c = newclass 'Child'
--
1.5.0.2.21.gdcde2

Reply all
Reply to author
Forward
0 new messages