[perl #42305] [PATCH]: Configure.pl: Move STDOUT messages to Parrot::Configure::Messages

Skip to first unread message

James Keenan

Apr 4, 2007, 10:09:24 PM4/4/07
to bugs-bi...@rt.perl.org
# New Ticket Created by James Keenan
# Please include the string: [perl #42305]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=42305 >

This patch transfers one aspect of Configure.pl's functionality --
the user-friendly messages it print to STDOUT at the beginning and
end of the configuration process -- out of that script and places it
in a new package: lib/Parrot/Configure/Messages.pm.

Parrot::Configure::Options exports two subroutines on demand:

By placing this functionality in subroutines exported by a class, we
can write tests for it using Perl's standard testing apparatus.
Accordingly, a test file is supplied as part of this patch:

This is the second in a series of patches which a number of Parrot
hackers and I will be submitting a series of patches which refactor
Configure.pl and the various Parrot::Configure::* classes. This
refactoring will be focused primarily on increasing the testability
-- and, by extension, the long-term maintainability -- of Parrot's
configuration code.

Assuming no bug reports are received, we will apply this patch to
trunk in approximately 3 days. Thank you very much.



James Keenan via RT

Apr 7, 2007, 4:00:51 PM4/7/07
to perl6-i...@perl.org
Patch committed to trunk in r18027.
Reply all
Reply to author
0 new messages