Just a note that we cannot deprecate the double-underscore method
of overriding vtable methods until RT #40626 is resolved.
RT #40626 notes that the :vtable pragma isn't currently working
for PIR code compiled into .pbc files -- see the sample program
in RT #40626. And, just for completeness, I tried the test program
after applying the patch in #41364 and got the same results
(this is not unexpected, I'm guessing that #41364 is addressing
a different issue).
Thanks. The patch looks good. Could you also supply a regression test
that demonstrates what was failing before the patch, and passes with the
patch applied? Something along the lines of the attached patch, though I
only spent a few minutes on it and expect you'll want to expand it.
On 2/19/07, Alek Storm <alek....@gmail.com> wrote:
> Thanks for the head start; now I know to include a test in the future.
> Here is an updated version of your patch, with various minor fixes.
reference to `find_vtable_meth'
collect2: ld returned 1 exit status
After applying it. Any ideas?
> > Now that 0.4.9 has been released, can this be committed?
On 3/15/07, Will Coleda via RT <parrotbug...@parrotcode.org> wrote:
> Can't apply this patch:
> $ patch -p0 < foo.patch
> patching file CREDITS
> Hunk #1 succeeded at 572 (offset 19 lines).
> patching file src/ops/object.ops
> Hunk #1 FAILED at 54.
> Hunk #2 FAILED at 92.
> Hunk #3 FAILED at 128.
> 3 out of 3 hunks FAILED -- saving rejects to file src/ops/object.ops.rej
> patching file src/pmc/parrotobject.pmc
> Hunk #1 succeeded at 164 (offset -38 lines).
> On Sun Mar 04 19:33:30 2007, alek....@gmail.com wrote:
> > Just kidding! Here's the patch, for real this time.
> > On 3/4/07, Alek Storm <alek....@gmail.com> wrote:
> > > That's because the patch refers to a function that is now outdated
> > because
> > > of #41549. I've attached an updated version of the patch.
> > >
> > > Thanks,
> > > Alek Storm
> > >
> > > On 3/2/07, jn...@jnthn.net via RT <parrotbug-
This was wanted in the next release, so I applied the bits that weren't
applying with patch manually. Applied your tests as well. All checked in