[PATCH] Test::Class and blead

[Nicholas Clark]

Test::Class and blead didn't quite get on. It found an issue with
Attribute::Handlers which I fixed with change 29414. However, it still
fails one test:

t/test_method..........ok 1/16\A+ matches null string many times in regex; marked by <-- HERE in m/\A+ <-- HERE +\z/ at /Users/nick/.cpan/build/Test-Class-0.21-2cHgAT/blib/lib/Test/Class.pm line 140.
\A+ matches null string many times in regex; marked by <-- HERE in m/\A+ <-- HERE +\z/ at /Users/nick/.cpan/build/Test-Class-0.21-2cHgAT/blib/lib/Test/Class.pm line 144.

# Failed test '$ENV{TEST_METHOD} with an invalid regex should die'
# at t/test_method.t line 63.
t/test_method..........NOK 13/16# ''
# doesn't match '(?-xism:\ATEST_METHOD\ \(\+\+\)\ is\ not\ a\ valid\ regular\ expression)'
# Looks like you failed 1 test of 16.
t/test_method..........dubious
Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 13
Failed 1/16 tests, 93.75% okay

This is because ++ is now a valid quantifier, thanks to Yves' regexp heroics.

The tersest patch I can find to "fix" this is

--- t/test_method.t~ 2006-11-01 23:39:51.000000000 +0000
+++ t/test_method.t 2006-11-29 10:34:03.000000000 +0000
@@ -58,9 +58,9 @@
$ENV{TEST_COUNT} = 3;
Foo->new->runtests;

-$ENV{TEST_METHOD} = '++';
+$ENV{TEST_METHOD} = '+++';
eval { Foo->new->runtests };
-like $@, qr/\A\QTEST_METHOD (++) is not a valid regular expression/,
+like $@, qr/\A\QTEST_METHOD (+++) is not a valid regular expression/,
'$ENV{TEST_METHOD} with an invalid regex should die';

$ENV{TEST_METHOD} = 'customer1';

+++ is still an invalid regexp.
Modems everywhere will love me. :-)

Nicholas Clark