[PATCH] 5.8.3 - various

[Brendan O'Dea]

I've applied the following patches (attached) to the Debian 5.8.3-2
release. In order:

01_fix_instmodsh_doc
Add some basic POD to lib/ExtUtils/instmodsh so taht it has a
manpage.

02_fix_base_pseudohash_warn
As mentioned on P5P <20040208214...@londo.c47.org>,
supress pseudohash warning in cases where the derived class
doesn't add any additioan fields.

03_fix_hurd_build
Patch for building on the hurd.

04_fix_encode_doc
Doc fix (typo).

05_fix_perluniintro
Doc fix (logic).

--bod

[H.Merijn Brand]

On Sun 15 Feb 2004 13:27, "Brendan O'Dea" <b...@debian.org> wrote:
> 01_fix_instmodsh_doc
> Add some basic POD to lib/ExtUtils/instmodsh so taht it has a
> manpage.

Thanks, applied as change #22308

--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.0, & 5.9.x, and 806 on HP-UX 10.20 & 11.00, 11i,
AIX 4.3, SuSE 8.2, and Win2k. http://www.cmve.net/~merijn/
http://archives.develooper.com/daily...@perl.org/ per...@perl.org
send smoke reports to: smokers...@perl.org, QA: http://qa.perl.org

[H.Merijn Brand]

On Sun 15 Feb 2004 13:27, "Brendan O'Dea" <b...@debian.org> wrote:

> --- perl-5.8.3.orig/ext/MIME/Base64/Base64.xs 2003-10-15 20:26:45.000000000 +1000
> +++ perl-5.8.3/ext/MIME/Base64/Base64.xs 2004-02-15 11:19:16.000000000 +1100
> @@ -341,7 +341,7 @@
> }
> else {
> /* output escaped char (with line breaks) */
> - assert(p < end)
> + assert(p < end);
> if (eol_len && linelen > MAX_LINE - 4) {
> sv_catpvn(RETVAL, "=", 1);
> sv_catpvn(RETVAL, eol, eol_len);

Thanks applies as change #22309

[H.Merijn Brand]

On Sun 15 Feb 2004 13:27, "Brendan O'Dea" <b...@debian.org> wrote:

> 04_fix_encode_doc
> Doc fix (typo).

Thanks, applied as change #22310

[Andy Dougherty]

In perl.perl5.porters, you wrote:
>--7JfCtLOvnd9MIVvH
>Content-Type: text/plain; charset=us-ascii
>Content-Disposition: inline

>
>I've applied the following patches (attached) to the Debian 5.8.3-2
>release. In order:
>

> 03_fix_hurd_build
> Patch for building on the hurd.

>diff -Naur --exclude=debian perl-5.8.3.orig/Configure perl-5.8.3/Configure
>--- perl-5.8.3.orig/Configure 2003-12-05 22:57:56.000000000 +1100
>+++ perl-5.8.3/Configure 2004-02-15 11:19:16.000000000 +1100
>@@ -3112,6 +3112,8 @@
> freebsd) osname=freebsd
> osvers="$3" ;;
> genix) osname=genix ;;
>+ gnu) osname=gnu
>+ osvers="$3" ;;
> hp*) osname=hpux
> osvers=`echo "$3" | $sed 's,.*\.\([0-9]*\.[0-9]*\),\1,'`
> ;;

Odd. This shouldn't have been necessary. That's what the default
should have ended up doing anyway. The patch is probably harmless too,
but it does strike me as curious. Do you know anyone who could send a
copy of the output of uname -a on a Hurd system? If nothing else, it
would be useful to include it in a comment somewhere.

Thanks,

--
Andy Dougherty doug...@lafayette.edu

[H.Merijn Brand]

FWIW, the metaunit has a lot of comments with the hpux line that do not
promote to Configure.

I see no difference between the 'gnu' change here, and the 'freebsd' two lines
above, and I found no documentation for that either.

Currently I'm trying to restore Configure to a working state after the
regeneration yields buckets full of diffs after Dave Michell's work

All explainable and work-aroundable, but I wanna do it correct

[H.Merijn Brand]

On Sun 15 Feb 2004 13:27, "Brendan O'Dea" <b...@debian.org> wrote:

> 03_fix_hurd_build
> Patch for building on the hurd.

Thanks, applied (as part of) change #22314

[Brendan O'Dea]

On Mon, Feb 16, 2004 at 11:20:52AM -0500, Andy Dougherty wrote:
>In perl.perl5.porters, you wrote:

>> 03_fix_hurd_build
>> Patch for building on the hurd.
>
>>diff -Naur --exclude=debian perl-5.8.3.orig/Configure perl-5.8.3/Configure
>>--- perl-5.8.3.orig/Configure 2003-12-05 22:57:56.000000000 +1100
>>+++ perl-5.8.3/Configure 2004-02-15 11:19:16.000000000 +1100
>>@@ -3112,6 +3112,8 @@
>> freebsd) osname=freebsd
>> osvers="$3" ;;
>> genix) osname=genix ;;
>>+ gnu) osname=gnu
>>+ osvers="$3" ;;
>> hp*) osname=hpux
>> osvers=`echo "$3" | $sed 's,.*\.\([0-9]*\.[0-9]*\),\1,'`
>> ;;
>
>
>Odd. This shouldn't have been necessary. That's what the default
>should have ended up doing anyway. The patch is probably harmless too,
>but it does strike me as curious. Do you know anyone who could send a
>copy of the output of uname -a on a Hurd system? If nothing else, it
>would be useful to include it in a comment somewhere.

I asked around and got two samples:

GNU blackbird.oase.mhn.de 0.3 GNU-Mach 1.4/Hurd-0.3 i386-AT386 GNU
GNU gnu 0.3 GNUmach-1.2/Hurd-0.3 i386-AT386 GNU

Note the hostname on the second one (from the patch submitter's machine)
which probably causes the SYSV case, where $1 == $2 to be used rather
than the fallback.

--bod

[Andrew Dougherty]

Thanks. That explains it. In any case, it's always good to have an
actual sample. I'll suggest some sort of appropriate patch.

--
Andy Dougherty doug...@lafayette.edu