Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH@33547] configure.com and vms.c fixes.

0 views
Skip to first unread message

John E. Malmberg

unread,
Mar 23, 2008, 3:29:25 PM3/23/08
to perl5-...@perl.org, vms...@perl.org, craig...@mac.com
In configure.com, add test for sys/poll.h.

In VMS.C, Add a missing translation of an RMS status code to a ERRNO,
and remove a cast.

-John
wb8...@qsl.net
Personal Opinion Only

configure_com.gdiff
vms_c.gdiff

H.Merijn Brand

unread,
Mar 24, 2008, 4:27:44 AM3/24/08
to John E. Malmberg, perl5-...@perl.org, vms...@perl.org, craig...@mac.com
On Sun, 23 Mar 2008 14:29:25 -0500, "John E. Malmberg" <wb8...@qsl.net> wrote:

> In configure.com, add test for sys/poll.h.
>
> In VMS.C, Add a missing translation of an RMS status code to a ERRNO,
> and remove a cast.

Thanks John, applied as change #33550

FYI, this test was added by the updated metaconfig tools, not by any
patch from the perl community, so it missing in any of the OS's that
do not use Configure was not a big deal.

However, this is good housekeeping. I'd love to see the remaining OS
variants updated too.

--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/

John E. Malmberg

unread,
Mar 24, 2008, 10:09:44 AM3/24/08
to H.Merijn Brand, John E. Malmberg, perl5-...@perl.org, vms...@perl.org, craig...@mac.com
H.Merijn Brand wrote:
> On Sun, 23 Mar 2008 14:29:25 -0500, "John E. Malmberg" <wb8...@qsl.net> wrote:
>
>> In configure.com, add test for sys/poll.h.
>>
> Thanks John, applied as change #33550
>
> FYI, this test was added by the updated metaconfig tools, not by any
> patch from the perl community, so it missing in any of the OS's that
> do not use Configure was not a big deal.

The test being missing from configure.com prevented Perl from building
on VMS.

> However, this is good housekeeping. I'd love to see the remaining OS
> variants updated too.

-John
wb8...@qsl.net
Personal Opinion Only


Craig A. Berry

unread,
Mar 25, 2008, 11:41:56 PM3/25/08
to H.Merijn Brand, John E. Malmberg, perl5-...@perl.org, vms...@perl.org
At 9:27 AM +0100 3/24/08, H.Merijn Brand wrote:
>On Sun, 23 Mar 2008 14:29:25 -0500, "John E. Malmberg" <wb8...@qsl.net> wrote:
>
> > In configure.com, add test for sys/poll.h.

>Thanks John, applied as change #33550

Thanks for keeping up with VMS patches while my attention was elsewhere.

>FYI, this test was added by the updated metaconfig tools, not by any
>patch from the perl community, so it missing in any of the OS's that
>do not use Configure was not a big deal.
>
>However, this is good housekeeping. I'd love to see the remaining OS
>variants updated too.

On Mac OS X, I'm seeing:

<poll.h> found.
Hmm. Based on the hints in hints/darwin.sh,
the recommended value for $i_poll on this machine was "undef"!
Keep the recommended value? [y]

Do all the hints files need to be updated? The IO extension includes
poll.h unconditionally, so pretty much everything must have it.

--
________________________________________
Craig A. Berry
mailto:craig...@mac.com

"... getting out of a sonnet is much more
difficult than getting in."
Brad Leithauser

H.Merijn Brand

unread,
Mar 26, 2008, 5:15:20 AM3/26/08
to Craig A. Berry, John E. Malmberg, perl5-...@perl.org, vms...@perl.org
On Tue, 25 Mar 2008 22:41:56 -0500, "Craig A. Berry" <craig...@mac.com>
wrote:

> At 9:27 AM +0100 3/24/08, H.Merijn Brand wrote:
> >On Sun, 23 Mar 2008 14:29:25 -0500, "John E. Malmberg" <wb8...@qsl.net> wrote:
> >
> > > In configure.com, add test for sys/poll.h.
>
>
> > Thanks John, applied as change #33550
>
> Thanks for keeping up with VMS patches while my attention was elsewhere.
>
> > FYI, this test was added by the updated metaconfig tools, not by any
> > patch from the perl community, so it missing in any of the OS's that
> > do not use Configure was not a big deal.
> >
> > However, this is good housekeeping. I'd love to see the remaining OS
> > variants updated too.
>
> On Mac OS X, I'm seeing:
>
> <poll.h> found.
> Hmm. Based on the hints in hints/darwin.sh,
> the recommended value for $i_poll on this machine was "undef"!
> Keep the recommended value? [y]
>
> Do all the hints files need to be updated? The IO extension includes
> poll.h unconditionally, so pretty much everything must have it.

I obviously underestimated the effect of this automatically being added
by the new configuration stuff.

If poll.h is automatically always included, we are either doing it wrong
or we have no alternatives, in which case the check would be void. I can
remove it if that would be preferred.

Craig A. Berry

unread,
Mar 26, 2008, 8:57:08 PM3/26/08
to H.Merijn Brand, perl5-...@perl.org, vms...@perl.org
At 10:15 AM +0100 3/26/08, H.Merijn Brand wrote:
>On Tue, 25 Mar 2008 22:41:56 -0500, "Craig A. Berry" <craig...@mac.com>
>wrote:
>
>> At 9:27 AM +0100 3/24/08, H.Merijn Brand wrote:
>> >On Sun, 23 Mar 2008 14:29:25 -0500, "John E. Malmberg" <wb8...@qsl.net> wrote:
>> >
> > > > In configure.com, add test for sys/poll.h.

> > > FYI, this test was added by the updated metaconfig tools, not by any
>> > patch from the perl community, so it missing in any of the OS's that
>> > do not use Configure was not a big deal.
>> >
>> > However, this is good housekeeping. I'd love to see the remaining OS
>> > variants updated too.
>>
>> On Mac OS X, I'm seeing:
>>
>> <poll.h> found.
>> Hmm. Based on the hints in hints/darwin.sh,
>> the recommended value for $i_poll on this machine was "undef"!
>> Keep the recommended value? [y]
>>
>> Do all the hints files need to be updated? The IO extension includes
>> poll.h unconditionally, so pretty much everything must have it.

I was wrong about that. IO includes its own local poll.h, and
ext/IO/poll.h has

#if (defined(HAS_POLL) && defined(I_POLL)) || defined(POLLWRBAND)
# include <poll.h>
#else
#ifdef HAS_SELECT

I'm also confused about i_poll vs. i_syspoll. Only the latter is
new. So if the Mac OS X (Leopard) hints are wrong, it is only for
i_poll, not the new i_syspoll.


>I obviously underestimated the effect of this automatically being added
>by the new configuration stuff.
>
>If poll.h is automatically always included, we are either doing it wrong
>or we have no alternatives, in which case the check would be void. I can
>remove it if that would be preferred.

Probably ignoring me would be safer. But I am genuinely confused
about the difference, if any, between poll.h and sys/poll.h. If they
are just different locations for the same thing, should Perl really
have two configuration settings?

John E. Malmberg

unread,
Mar 26, 2008, 9:42:12 PM3/26/08
to Craig A. Berry, H.Merijn Brand, perl5-...@perl.org, vms...@perl.org
Craig A. Berry wrote:
> At 10:15 AM +0100 3/26/08, H.Merijn Brand wrote:
>> On Tue, 25 Mar 2008 22:41:56 -0500, "Craig A. Berry" <craig...@mac.com>
>> wrote:
<snip>

> I was wrong about that. IO includes its own local poll.h, and
> ext/IO/poll.h has
>
> #if (defined(HAS_POLL) && defined(I_POLL)) || defined(POLLWRBAND)
> # include <poll.h>
> #else
> #ifdef HAS_SELECT
>
> I'm also confused about i_poll vs. i_syspoll. Only the latter is
> new. So if the Mac OS X (Leopard) hints are wrong, it is only for
> i_poll, not the new i_syspoll.

The X/Open group, which is the keeper of the UNIX and POSIX standards
only lists a poll.h.

The standard is on-line for free viewing at http://www.opengroup.org.
Registration may be required. I have never received anything but a
confirmation of registration from them.

I am finding a lot of hits indicating that programmers are expecting it
to be in sys/poll.h.

A check of a Centos system shows that <poll.h> simply does an include of
<sys/poll.h>

Cygwin is doing the same.


>> I obviously underestimated the effect of this automatically being added
>> by the new configuration stuff.
>>
>> If poll.h is automatically always included, we are either doing it wrong
>> or we have no alternatives, in which case the check would be void. I can
>> remove it if that would be preferred.
>
> Probably ignoring me would be safer. But I am genuinely confused
> about the difference, if any, between poll.h and sys/poll.h. If they
> are just different locations for the same thing, should Perl really
> have two configuration settings?

If a <poll.h> is found, then the implementation is standard, and that is
the file that should be used, and there is no need to look for a
<sys/poll.h>

If <poll.h> is not found, but <sys/poll.h> is present, then that can be
a fallback. It might be useful to emit a diagnostic that the
implementation is not compliant with the UNIX standard.

Note that VMS ignores the path in system header files, so <poll.h>,
<sys/poll.h> and <foo/poll.h> are all the same.

0 new messages