storing non-sv pointers in mg_obj causes crashes
Marc Lehmann
Event stores (c/typemap.c) a private pointer in mg_obj. This causes perl to
crash (or, worse, silent memory corruption) whenever perl tries to duplicate
the magic (e.g. when creating a thread, or forking under windows), as perl
calls either sv_dup or sv_dup_inc on mg_obj, which in this case is not a
valid SV *.
Fixing c/typemap.c by replacing all (both) occurrences of mg_obj by the
corretc mg_ptr fixes this problem, and seems to work (although I have not
given this issue much testing or verification once I identified it, this
is likely all thats required, as other uses of magic in Event seem safe).
Joshua: in case you lack the time for a fix, my offer to maintain Event still
stands (and I woudl certainly give the fix more thought then :), but I
happily see that you seem to be quite active in the last months *g*.
PS: thanks for wrapping everything into typemap.c instead of sprinkling it
randomly around :)
--
The choice of a
-----==- _GNU_
----==-- _ generation Marc Lehmann
---==---(_)__ __ ____ __ p...@goof.com
--==---/ / _ \/ // /\ \/ / http://schmorp.de/
-=====/_/_//_/\_,_/ /_/\_\ XX11-RIPE
Joshua N Pritikin
> Event stores (c/typemap.c) a private pointer in mg_obj. This causes perl to
> crash (or, worse, silent memory corruption) whenever perl tries to duplicate
> the magic (e.g. when creating a thread, or forking under windows), as perl
> calls either sv_dup or sv_dup_inc on mg_obj, which in this case is not a
> valid SV *.
That's not good!
> Fixing c/typemap.c by replacing all (both) occurrences of mg_obj by the
> corretc mg_ptr fixes this problem, and seems to work (although I have not
> given this issue much testing or verification once I identified it, this
> is likely all thats required, as other uses of magic in Event seem safe).
Interesting.
I don't see a problem with mg_ptr. The test suite still passes.
I'll make the change. Let's see if anybody complains about it.
--
Make April 15 just another day, visit http://fairtax.org