Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[rt.cpan.org #82611] make tool detection broken in Win32::API

5 views
Skip to first unread message

Daniel Dragan via RT

unread,
Feb 4, 2013, 1:43:53 AM2/4/13
to libw...@perl.org
Mon Feb 04 01:43:52 2013: Request 82611 was acted upon.
Transaction: Correspondence added by BULKDD
Queue: Win32-API
Subject: make tool detection broken in Win32::API
Broken in: 0.74, 0.75
Severity: Normal
Owner: Nobody
Requestors: BUL...@cpan.org
Status: open
Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82611 >


On Tue Jan 22 14:41:02 2013, BULKDD wrote:
>
> After discussion with Mithaldu/smoker owner above, {MAKE} is
> 'C:\Perl\site\bin\dmake.exe', not 'dmake.exe' on his machine.
> MM_Win32.pm has a is_make_type method which uses a more elaborate RE to
> do it. Using is_make_type will probably be the solution. Remaining
> issues are, is_make_type is not public API of EUMM (embedding the RE is
> the alternative), and testing the whole thing on VC Perl, S Perl and Cyg
> Perl.

Also remove the Encode:: dependency in makefile.pl, add a dependency on
Encode::compat, on 5.8 and newer on Win32 Encode::compat passes,
http://www.cpantesters.org/distro/E/Encode-compat.html . So this might
have Perl 5.6 reports show up in cpantesters for Win32::API. Also add
skipping the native threads with API::Callback threads test that crashes
on 5.6.

Daniel Dragan via RT

unread,
Feb 6, 2013, 11:28:12 PM2/6/13
to libw...@perl.org
Wed Feb 06 23:28:10 2013: Request 82611 was acted upon.
Transaction: Correspondence added by BULKDD
Queue: Win32-API
Subject: make tool detection broken in Win32::API
Broken in: 0.74, 0.75
Severity: Normal
Owner: Nobody
Requestors: BUL...@cpan.org
Status: open
Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82611 >


On Mon Feb 04 01:43:52 2013, BULKDD wrote:
> On Tue Jan 22 14:41:02 2013, BULKDD wrote:
> >
> > After discussion with Mithaldu/smoker owner above, {MAKE} is
> > 'C:\Perl\site\bin\dmake.exe', not 'dmake.exe' on his machine.
> > MM_Win32.pm has a is_make_type method which uses a more elaborate RE to
> > do it. Using is_make_type will probably be the solution. Remaining
> > issues are, is_make_type is not public API of EUMM (embedding the RE is
> > the alternative), and testing the whole thing on VC Perl, S Perl and Cyg
> > Perl.
>
> Also remove the Encode:: dependency in makefile.pl, add a dependency on
> Encode::compat, on 5.8 and newer on Win32 Encode::compat passes,
> http://www.cpantesters.org/distro/E/Encode-compat.html . So this might
> have Perl 5.6 reports show up in cpantesters for Win32::API. Also add
> skipping the native threads with API::Callback threads test that crashes
> on 5.6.


Also improve the POD for how to pass NULL, in pack letter mode (NOT
prototype mode) for a 'P'. In prototype mode undef is NULL, but in
letter mode, 0 is NULL. There is live code (irc conversation) that uses
letter mode 0 for NULL. so dont break back compat see this old ::API
https://github.com/bulk88/perl5-win32-api/blob/067439edfd8fab5bc7f18f5bfb16fe7ff7a75259
/API.xs#L324

Daniel Dragan via RT

unread,
Feb 20, 2013, 2:15:36 AM2/20/13
to libw...@perl.org
Wed Feb 20 02:15:34 2013: Request 82611 was acted upon.
Transaction: Correspondence added by BULKDD
Queue: Win32-API
Subject: make tool detection broken in Win32::API
Broken in: 0.74, 0.75
Severity: Normal
Owner: Nobody
Requestors: BUL...@cpan.org
Status: open
Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=82611 >


On Wed Feb 06 23:28:10 2013, BULKDD wrote:
> Also improve the POD for how to pass NULL, in pack letter mode (NOT
> prototype mode) for a 'P'. In prototype mode undef is NULL, but in
> letter mode, 0 is NULL. There is live code (irc conversation) that
> uses
> letter mode 0 for NULL. so dont break back compat see this old ::API
> https://github.com/bulk88/perl5-win32-
> api/blob/067439edfd8fab5bc7f18f5bfb16fe7ff7a75259
> /API.xs#L324


more todo: get public opinions for putting a "scalar(@_) >= 3 &&
scalar(@_) <= 6" sanity check on ctor new(). Reason:
http://perlmonks.org/?node_id=1019723 .
0 new messages