New version in the works: 3.06

[Nate Wiger]

Hi all-

I have finally gotten around to integrating the misc patches to
resolve the major outstanding RT bugs. I have pushed a series of
commits to github: https://github.com/formbuilder/formbuilder

If you have any remaining issues, please chime in. Otherwise, I will
take a look at releasing FormBuilder 3.06 over the new week or so.

Cheers,
Nate

[Victor Porton]

Just intrigued, have you merged my patches (all in "devel" branch)?

http://perl-formbuilder.googlecode.com/svn/trunk/branches/devel/

If yes, thanks. If no, why?

04.09.2011, 01:00, "Nate Wiger" <nwi...@gmail.com>:

> Hi all-
>
> I have finally gotten around to integrating the misc patches to

> resolve the major outstanding RT bugs. О©╫I have pushed a series of
> commits to github: О©╫https://github.com/formbuilder/formbuilder
>
> If you have any remaining issues, please chime in. О©╫Otherwise, I will

> take a look at releasing FormBuilder 3.06 over the new week or so.
>
> Cheers,
> Nate

--
Victor Porton - http://portonvictor.org

[Victor Porton]

[I write this again with Google Groups because it does not send from
my email account.]

Take note also with this my patch in "devel" branch.
http://code.google.com/p/perl-formbuilder/source/detail?r=32

It is a bug fix unlike most of the other my patches which are new
features.

[Victor Porton]

Oops, I worked with SVN: http://code.google.com/p/perl-formbuilder/

Now I noticed you work with GitHub.

Are we finally moved to GitHub? Will SVN be used anymore? Should I re-
create my "devel" branch there?

See my commits at:
http://code.google.com/p/perl-formbuilder/source/list

On Sep 4, 12:00 am, Nate Wiger <nwi...@gmail.com> wrote:

[David Romero]

Hi Nate,

I have sent a patch to solve the chrome js issue, I hope you may add it to the new release,

Also I you add a way to change the "Other" label for the "Other" option on radio fields would be great.

Thanks

--
You received this message because you are subscribed to the Google Groups "perl-formbuilder" group.
To post to this group, send email to perl-for...@googlegroups.com.
To unsubscribe from this group, send email to perl-formbuild...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/perl-formbuilder?hl=en.

--
David Romero
-----------------------------------------------------------

[Nate Wiger]

Victor-

Thanks for your continued contributions - they are appreciated.

I did integrate your bugfix for the radio javascript.

I have not reviewed the other changes, as the repo moved to github
last year (I emailed the google group). The best way to make
improvements to FormBuilder now is:

1. Create a github.com account
2. Fork the main formbuilder repository (eg, so you have vporton/
formbuilder)
3. Commit your changes to vporton/formbuilder, and then send a "Pull
Request" on a PER-FEATURE basis so the changes can be reviewed)

I anticipate 3.06 being mainly a critical bugfix/refresh release, but
we should target new features for a 3.07 release.

Thanks,
Nate

[Wolfgang Radke]

Hi Nate,

I'm not familiar with Git yet, so I use this way

------Field.pm:------

Line 412 addeded: $pkg =~ s/\-/_/; # Special to allow 'datetime-local'

Reason:
If you use HTML5-forms, then there are new types which contain a hypen
('-'), which is not allowed in filenames and causes a crash
(I will supply the new types for 3.0.7)

----------Source/File.pm------------
Line 134 modified to:

if ($term =~ /^js/ || $term =~ /^on[a-z]/ || $term eq 'messages' || $term
eq 'comment' )

Reason: Comments should not be split on ','

--------------------------------
That's all (considering fixes)

Oh, and thanks for updating Formbuilder

Wolfgang

[Wolfgang Radke]

Hi all,

I'm using Source/File for all my forms.
All my forms use utf-8, but somehow this is not recognized.
Since I use german Umlauts that is a problem (perl 5.10.x.)

My solution was to add a line into Source::File to interprete all data as
utf-8 (see below).
But there should be a neater way to do this (or should I say 'a Nater way
to do this'?).

Line 74ff
for (@file) {
next if /^\s*$/ || /^\s*#/; # blanks and comments
next if /^\s*\[\%\s*\#|^\s*-*\%\]/; # TT comments too
chomp;
$_ = Encode::decode('utf-8',$_);
my($term, $line) = split /\s*:\s*/, $_, 2;

-----------
What did not work so far:
- Relying on BOM (I'm working on Unix AND windows and different editors do
not support BOM)

Any ideas?
Or is there an option to tell Source::File that everything is utf-8 and I
did not find it?

Wolfgang

[Nate Wiger]

Thanks Wolfgang - I have integrated these fixes into the main FormBuilder repo for 3.06.

-Nate

[Nate Wiger]

It would be fairly easy to add support for a special Source::File config value:

    encoding: utf8

Then, slightly modify your code:

    $_ = Encode::decode('utf-8',$_) if $utf8;

Would this work?

-Nate

--
You received this message because you are subscribed to the Google Groups "perl-formbuilder" group.

To post to this group, send email to perl-formbuilder@googlegroups.com.
To unsubscribe from this group, send email to perl-formbuilder+unsubscribe@googlegroups.com.

[Nate Wiger]

Victor-

I just went and reviewed these again - thanks.  Here's my thoughts:

1) add_before_option / add_after_option - look fine, thanks

2) CGI_SSI - looks like this was already included in the github merge, but I will double-check 

3) _submit that holds value using JavaScript DOM calls.  I'm concerned that this could break behavior.  I'd like to revisit it after we release 3.06.  The last big release was in 2007, and I'd hate to release a version that suddenly breaks people.

Thanks,

Nate

On Sat, Sep 3, 2011 at 2:06 PM, Victor Porton <por...@narod.ru> wrote:

Just intrigued, have you merged my patches (all in "devel" branch)?

http://perl-formbuilder.googlecode.com/svn/trunk/branches/devel/

If yes, thanks. If no, why?

04.09.2011, 01:00, "Nate Wiger" <nwi...@gmail.com>:

> Hi all-
>
> I have finally gotten around to integrating the misc patches to

> resolve the major outstanding RT bugs.  I have pushed a series of
> commits to github:  https://github.com/formbuilder/formbuilder
>
> If you have any remaining issues, please chime in.  Otherwise, I will

> take a look at releasing FormBuilder 3.06 over the new week or so.
>
> Cheers,
> Nate

--

Victor Porton - http://portonvictor.org

--
You received this message because you are subscribed to the Google Groups "perl-formbuilder" group.

To post to this group, send email to perl-for...@googlegroups.com.
To unsubscribe from this group, send email to perl-formbuild...@googlegroups.com.

[Wolfgang Radke]

Yes Nate, it would work.
And it wold be _very_ helpful :-)

Wolfgang

>> perl-formbuilder@googlegroups.**com<perl-for...@googlegroups.com>

>> .
>> To unsubscribe from this group, send email to

>> perl-formbuilder+unsubscribe@**googlegroups.com<perl-formbuilder%2Bunsu...@googlegroups.com>
>> .
>> For more options, visit this group at http://groups.google.com/**
>> group/perl-formbuilder?hl=en<http://groups.google.com/group/perl-formbuilder?hl=en>
>> .
>>
>>