In a PR comment, Micah asked if it would make sense to instead build the pdfcabinet upon/into scanningcabinet. I feel like it is better to try and continue this discussion here rather than in the PR.
If nobody cares about scanningcabinet, perhaps the best thing to do is to remove it.
If someone does care about scanningcabinet, how would you feel about merging pdf functionality into it? The primary difference, I think is the 1:1 nature of of pdfs and documents where scanningcabinet expects multiple images(pages) per document.
That will show up in the UI, especially in the creation of documents. In scanningcabinet, you are expected to select some images, then click the button to turn that into a document. In pdfcabinet, you click the button associated with the pdf you want. Each flow should ideally be optimized for the user, to make it easy to create documents quickly.
If we were to try to merge pdfcabinet/scanningcabinet together, I lean towards some kind of mode the user can set to decide how they want to create documents (selecting multiple items vs. a single item).
The display of documents will also be affected by this. scanningcabinet lays out multiple images (using img tags I assume) where pdfcabinet uses an object to embed the pdf into the html page. This seems manageable...just thinking out loud, but I lean towards, at document creation time, marking the document permanode with an attribute to indicate which kind it is.
Does anyone else have thoughts related to this?
- Gina