patch: kill if idle - where should I submit it?

6 views
Skip to first unread message

David Stainton

unread,
Nov 12, 2010, 3:19:03 PM11/12/10
to perco...@googlegroups.com
Hi,

I'd like to submit the kill-if-idle (google feature) patch to percona-server.
We use it here at Spinn3r to gracefully remove mysql client
connections from our database for master demotions/slave promotions,
for rolling upgrades etc...
I think kill-if-idle may be useful for others as well.

I'd like to see kill-if-idle become part of percona-server.
I've previously submitted this google mysql feature to ourdelta:

http://ourdelta.org/docs/kill-if-idle

Where would be place to submit this patch?
How should I use the percona-server launchpad to submit this code?

I have attached my kill-if-idle patch (i extracted this google code -
i didn't write it) which I used to patch the debian source package
percona-server-5.1.51-11.5-132.lenny
(http://www.percona.com/downloads/Percona-Server-5.1/Percona-Server-5.1.51-11.5/deb/lenny/x86_64/percona-server-dfsg-5.1_5.1.51-11.5-132.lenny.tar.gz)


Cheers,

David

percona-server-5.1.51-11.5-132.lenny-kii.patch

Vadim Tkachenko

unread,
Nov 13, 2010, 11:51:03 AM11/13/10
to perco...@googlegroups.com
David,

Thanks  for the patch!

Best way for us is you propose merge to lp:percona-server.

Also it should have test coverage in mysql-test suite.

Thanks,
Vadim

> --
> You received this message because you are subscribed to the Google Groups "Percona Dev" group.
> To post to this group, send email to perco...@googlegroups.com.
> To unsubscribe from this group, send email to percona-dev...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/percona-dev?hl=en.
>
>


--
Vadim Tkachenko, CTO, Percona Inc.
Phone +1-888-401-3403, Skype: vadimtk153
Schedule meeting: http://tungle.me/VadimTkachenko

David Stainton

unread,
Feb 25, 2011, 5:37:51 PM2/25/11
to perco...@googlegroups.com
Greetings,

I'd like to push to my branch (so far it is empty:
https://code.launchpad.net/~david-spinn3r/percona-server/kill_if_idle)
and then propose the merge to lp:percona-server.

I did this:
bzr branch lp:percona-server

and got the repository of patches. However the Makefile suggests that
I should be using this to patch MYSQL_VERSION=5.1.55.
So I found mysql-5.1.55 here:
http://dev.mysql.com/downloads/mysql/5.1.html#downloads

Should I make the kill_if_idle patch work with mysql-5.1.55?
Do I then make a branch of lp:percona-server with this patch file added to it?

I've already sent you a patch earlier in this thread.
I however made this patch against the percona debian source package.

I'd be happy to let someone else do this. I'm not very familiar with
your build system and working with launchpad.
I am now attempting to make it easier for you to integrate this patch
into percona-server.

David

David Stainton

unread,
Feb 26, 2011, 2:57:26 AM2/26/11
to perco...@googlegroups.com
Hi Alexey,

Thats great. Thanks.
I'd suggest there be 2 tests:

Try to kill an idle connection and verify it was killed.
Try to kill a busy connection and verify it was not killed.

KILL IF_IDLE <connection_id> - Kill connection, but only if the
specified connection is idle.

Cheers,

David

On Fri, Feb 25, 2011 at 11:36 PM, Alexey Kopytov <akop...@gmail.com> wrote:
> Hi David,
>
> I created https://bugs.launchpad.net/percona-server/+bug/725436 to track
> the progress on this.


>
> On 26.02.11 1:37, David Stainton wrote:
>> Greetings,
>>
>> I'd like to push to my branch (so far it is empty:
>> https://code.launchpad.net/~david-spinn3r/percona-server/kill_if_idle)
>> and then propose the merge to lp:percona-server.
>>
>> I did this:
>> bzr branch lp:percona-server
>>
>> and got the repository of patches. However the Makefile suggests that
>> I should be using this to patch MYSQL_VERSION=5.1.55.
>> So I found mysql-5.1.55 here:
>> http://dev.mysql.com/downloads/mysql/5.1.html#downloads
>>
>> Should I make the kill_if_idle patch work with mysql-5.1.55?
>

> Yes, unless it is decided to integrate the patch only to Percona Server
> 5.5. In which case lp:percona-server/5.5 and MySQL 5.5.9 would have to
> be used.


>
>> Do I then make a branch of lp:percona-server with this patch file added to it?
>>
>

> Generally, yes, except that the branch is yet to be decided.


>
>> I've already sent you a patch earlier in this thread.
>> I however made this patch against the percona debian source package.
>>
>> I'd be happy to let someone else do this. I'm not very familiar with
>> your build system and working with launchpad.
>> I am now attempting to make it easier for you to integrate this patch
>> into percona-server.
>>
>

> OK, I think we can take it from here.
>
> So before this patch becomes a part of Percona Server we need to a)
> decide whether the patch should be included to both 5.1 and 5.5 or only
> to 5.5 b) write a test case for it.
>
> Thanks and regards,
> Alexey.

Alexey Kopytov

unread,
Feb 26, 2011, 2:36:04 AM2/26/11
to perco...@googlegroups.com, David Stainton
Hi David,

I created https://bugs.launchpad.net/percona-server/+bug/725436 to track
the progress on this.

On 26.02.11 1:37, David Stainton wrote:

> Greetings,
>
> I'd like to push to my branch (so far it is empty:
> https://code.launchpad.net/~david-spinn3r/percona-server/kill_if_idle)
> and then propose the merge to lp:percona-server.
>
> I did this:
> bzr branch lp:percona-server
>
> and got the repository of patches. However the Makefile suggests that
> I should be using this to patch MYSQL_VERSION=5.1.55.
> So I found mysql-5.1.55 here:
> http://dev.mysql.com/downloads/mysql/5.1.html#downloads
>
> Should I make the kill_if_idle patch work with mysql-5.1.55?

Yes, unless it is decided to integrate the patch only to Percona Server


5.5. In which case lp:percona-server/5.5 and MySQL 5.5.9 would have to
be used.

> Do I then make a branch of lp:percona-server with this patch file added to it?
>

Generally, yes, except that the branch is yet to be decided.

> I've already sent you a patch earlier in this thread.


> I however made this patch against the percona debian source package.
>
> I'd be happy to let someone else do this. I'm not very familiar with
> your build system and working with launchpad.
> I am now attempting to make it easier for you to integrate this patch
> into percona-server.
>

OK, I think we can take it from here.

So before this patch becomes a part of Percona Server we need to a)
decide whether the patch should be included to both 5.1 and 5.5 or only
to 5.5 b) write a test case for it.

Thanks and regards,
Alexey.

> David

Reply all
Reply to author
Forward
0 new messages