Issue 70 in pencil-code: lstarting is almost everywhere, but in cparam.f90

[penci...@googlecode.com]

Status: Accepted
Owner: Bourdin.KIS
Labels: Type-Enhancement Priority-Medium

New issue 70 by Bourdin.KIS: lstarting is almost everywhere, but in
cparam.f90
http://code.google.com/p/pencil-code/issues/detail?id=70

In the code, I find really many places, where "lstarting" is used to
distinguish between "start" and "run". Wouldn't it make much more sense to
put this in cparam.f90, because that is practically available globally?
This would make the code cleaner, and especially, the flag (and its
meaning) is then forced to be consistent everywhere.

Besides that, it would actually also make sense to add "lrun" there, too,
making some logic checks a bit easier by an abbreviation of "(.not.
lstarting)" => "(lrun)".

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[penci...@googlecode.com]

Comment #1 on issue 70 by Bourdin.KIS: lstarting is almost everywhere, but
in cparam.f90
http://code.google.com/p/pencil-code/issues/detail?id=70

Just btw. 'lrun' and 'lstart' are already available in cdata.f90.
So 'lstarting' is redundant and might be replaced by 'lstart'.

[penci...@googlecode.com]

Updates:
Status: Fixed

Comment #2 on issue 70 by Bourdin.KIS: lstarting is almost everywhere, but
in cparam.f90
https://code.google.com/p/pencil-code/issues/detail?id=70

Fixed with r22442. Level-1-Autotest went fine, now waiting for verification
by daily autotest.