[pencil-code/pencil-code] 962fea: eos_idealgas_vapor: get_gamma_etc: gamma is actual...
1 view
Skip to first unread message
Kishore96in
Dec 11, 2024, 6:30:19 AM12/11/24
to pencil-co...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/pencil-code/pencil-code
Commit: 962fea3624f66b9a1737357df29e870e4d5cbc8a
https://github.com/pencil-code/pencil-code/commit/962fea3624f66b9a1737357df29e870e4d5cbc8a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: get_gamma_etc: gamma is actually a constant in this module
Commit: 306d4df04acb528f29c35dfae5720b0ef0480f0a
https://github.com/pencil-code/pencil-code/commit/306d4df04acb528f29c35dfae5720b0ef0480f0a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: option to have cp as auxiliary variable
Commit: 050b00fd4f50cb5c86ad7f5309292f92b8f5c080
https://github.com/pencil-code/pencil-code/commit/050b00fd4f50cb5c86ad7f5309292f92b8f5c080
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: move pencils for aux to pencil_criteria_eos
Commit: 36b6b24b5e04beb31f8ee186932ec6f9a56e94ac
https://github.com/pencil-code/pencil-code/commit/36b6b24b5e04beb31f8ee186932ec6f9a56e94ac
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/get_gamma_etc: add f-array as an optional argument
So that cp can be obtained from it when lcp_as_aux=T. I think that for
other eos modules too, having the f-array would allow cp etc to be
calculated correctly within the get_gamma_etc subroutine.
Commit: 5fa0f7fd6032e1a65e6af750d6399c4997b78c4b
https://github.com/pencil-code/pencil-code/commit/5fa0f7fd6032e1a65e6af750d6399c4997b78c4b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: add some cparam declarations
Unclear why we say leos_idealgas=.true.
Commit: 323fb444dd8660e8f3697668f1edd05110219213
https://github.com/pencil-code/pencil-code/commit/323fb444dd8660e8f3697668f1edd05110219213
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: Implement bc_lnrho_temp_z
Commit: 95dc5664b30a0981630544eae5eddbe0b4e00060
https://github.com/pencil-code/pencil-code/commit/95dc5664b30a0981630544eae5eddbe0b4e00060
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: rm unused variable
Clashes with something in cdata
Commit: 8c53b37f7a6919b34384772b042faff902b20614
https://github.com/pencil-code/pencil-code/commit/8c53b37f7a6919b34384772b042faff902b20614
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: include dummy routines
Commit: 3d378820bcf4eff0a5618f7b1c1831f6c8520dfd
https://github.com/pencil-code/pencil-code/commit/3d378820bcf4eff0a5618f7b1c1831f6c8520dfd
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: correctly calculate vapour fraction
Have added a new pencil, fvap.
Axel, in commit e495afe2fecd170243aa475024da0f3f5b3fd632 ,
you made a change to treat p%ssat as the vapour fraction.
However, I think that should be calculated as in this commit.
Do you agree? I do not see eos_idealgas_vapor being used
in any samples, and so have taken the liberty of changing it.
Commit: 5c8c380fd78d47e2f1f4d9607234e54d08438b4b
https://github.com/pencil-code/pencil-code/commit/5c8c380fd78d47e2f1f4d9607234e54d08438b4b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/calc_pencils_eos_pencpar: intent inout for f array
Just as in eos_idealgas; needed when lcp_as_aux=T
Commit: 6fa2462497dcc72f13f7949b5323d298c87141c3
https://github.com/pencil-code/pencil-code/commit/6fa2462497dcc72f13f7949b5323d298c87141c3
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/calc_pencils_eos_pencpar: rm unused variable
Commit: 727fc518086c07b7978020f1adce090cde93ae5f
https://github.com/pencil-code/pencil-code/commit/727fc518086c07b7978020f1adce090cde93ae5f
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: include eos_params.h
Commit: 328bdd9667e75eb209c53acdd338b3ca859f5718
https://github.com/pencil-code/pencil-code/commit/328bdd9667e75eb209c53acdd338b3ca859f5718
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: update type of topbot for bc functions
Commit: dd3f2f05c8fab1982e6e953412601c1679a7207b
https://github.com/pencil-code/pencil-code/commit/dd3f2f05c8fab1982e6e953412601c1679a7207b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: add required public stuff
Commit: 2e3bd7c413eed5156d53be9ba6df1a88a10beb44
https://github.com/pencil-code/pencil-code/commit/2e3bd7c413eed5156d53be9ba6df1a88a10beb44
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: remove reference state stuff
Pretty sure it needs to be accounted for in other places too
Commit: 7859d09b6c4f80baba8f40d534c74d76a1c95c73
https://github.com/pencil-code/pencil-code/commit/7859d09b6c4f80baba8f40d534c74d76a1c95c73
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: move to be with other BCs
Still in the same file
Commit: 78ed1acafec99137d2c6b383db0b11732e23983e
https://github.com/pencil-code/pencil-code/commit/78ed1acafec99137d2c6b383db0b11732e23983e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/isothermal_entropy: update call signature
Copied from noeos
Commit: 4a4b5e765b2f6075194a04c3de9046970aea2644
https://github.com/pencil-code/pencil-code/commit/4a4b5e765b2f6075194a04c3de9046970aea2644
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/noeos.f90
Log Message:
-----------
noeos: add fatal error for unimplemented BCs
Commit: b256b72eb537a0f539cbce3de020d2938525e9e6
https://github.com/pencil-code/pencil-code/commit/b256b72eb537a0f539cbce3de020d2938525e9e6
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: rm unimplemented functions
eos_dummies already provides dummy implementations
Commit: 72932a067b1d82e7648ddba7db4e485a56d5ae0a
https://github.com/pencil-code/pencil-code/commit/72932a067b1d82e7648ddba7db4e485a56d5ae0a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: fatal error for unimplemented BCs
Commit: f519d01f08d559ab557a1600fdb3f72d51c2abc6
https://github.com/pencil-code/pencil-code/commit/f519d01f08d559ab557a1600fdb3f72d51c2abc6
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/initialize_eos: update call signature
Commit: 049f5b7581170c4008bb83f525b6fa1ee75c8eaf
https://github.com/pencil-code/pencil-code/commit/049f5b7581170c4008bb83f525b6fa1ee75c8eaf
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: add use statements
Compiles now
Commit: b06914b537c6d16baea619db6b36870eb1507d54
https://github.com/pencil-code/pencil-code/commit/b06914b537c6d16baea619db6b36870eb1507d54
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: put some shared variables
I think these guys are only used in density.f90 for the polytropic ICs
Commit: 7ae0ecf8a7ec161b3e9ab4c7f4ea6e9def0ccb49
https://github.com/pencil-code/pencil-code/commit/7ae0ecf8a7ec161b3e9ab4c7f4ea6e9def0ccb49
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: stricter argument declarations
Commit: 6fc0d2a006ae332a839b03f09d1c90713fbe0242
https://github.com/pencil-code/pencil-code/commit/6fc0d2a006ae332a839b03f09d1c90713fbe0242
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/get_gamma_etc: check that cp is not zero
For some reason, it ends up being zero even outside the ghost zones
Commit: 1967e038151412cc26c70352ac5c85a6a37899c5
https://github.com/pencil-code/pencil-code/commit/1967e038151412cc26c70352ac5c85a6a37899c5
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos.h
M src/equ.f90
M src/noeos.f90
Log Message:
-----------
Add eos_before_boundary subroutine
Only a dummy implementation in noeos for now.
Commit: 9be11a8a7be1c63cbf67e706445a6e8582b9609d
https://github.com/pencil-code/pencil-code/commit/9be11a8a7be1c63cbf67e706445a6e8582b9609d
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/cdata.f90
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: calculate cp etc in eos_before_boundary subroutine
Subroutine get_gamma_etc requires cp to be in the f-array. Usage of
get_gamma_etc in boundary condition routines then requires that cp be
present in the f-array before the boundary conditions are called.
Calculating cp requires fvap and mumol1; we then keep them in the
f-array
to avoid unnecessary recomputation if these are needed as pencils later
on.
Commit: 03ec91c3a9bd8879d075a96a408e8ca496ae54d7
https://github.com/pencil-code/pencil-code/commit/03ec91c3a9bd8879d075a96a408e8ca496ae54d7
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: use mx,my directly for index ranges
Commit: 0e992ba40c9c3038772b06f2b986eb33e573f0dd
https://github.com/pencil-code/pencil-code/commit/0e992ba40c9c3038772b06f2b986eb33e573f0dd
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/cdata.f90
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: remove indices for aux from cdata
I don't see any need right now for these to be globally available. They
can be moved to cdata later if it turns out another module needs them.
Commit: e31b5ea08c72c655b7ab3b7eb8b12073a02129f6
https://github.com/pencil-code/pencil-code/commit/e31b5ea08c72c655b7ab3b7eb8b12073a02129f6
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/get_gamma_etc: better fallback value for cv
Commit: a529664fb6d1085a5257419c70e452723a4713ed
https://github.com/pencil-code/pencil-code/commit/a529664fb6d1085a5257419c70e452723a4713ed
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/units_eos: do not reset lnTT0 to 0
Unclear why this was ever done. Ugh.
Commit: 4a43e5bacd59e0f5cce44137f55a1a08c43cc9eb
https://github.com/pencil-code/pencil-code/commit/4a43e5bacd59e0f5cce44137f55a1a08c43cc9eb
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: use gamma_m1 rather than gamma-1
Commit: 46596c0cba882839291f54165c69133e0b4e568d
https://github.com/pencil-code/pencil-code/commit/46596c0cba882839291f54165c69133e0b4e568d
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: fix sign mistake
Commit: 7eae299d92ed46052d7fa343db8f7f8fe7113071
https://github.com/pencil-code/pencil-code/commit/7eae299d92ed46052d7fa343db8f7f8fe7113071
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor.f90: remove dummy get_stratz
Will be included from noeos
Commit: 492cd438fee973d9f70ac3414453e78be0e08309
https://github.com/pencil-code/pencil-code/commit/492cd438fee973d9f70ac3414453e78be0e08309
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: remove dummy routines
These routines do not even raise an error, which does not seem right.
Commit: ba17c93fa95be77f31f799e50e3cd3cf58d42f1b
https://github.com/pencil-code/pencil-code/commit/ba17c93fa95be77f31f799e50e3cd3cf58d42f1b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: rm subroutine get_ptlaw which is no longer used anywhere
Commit: 076ba18cb4c054a9970353b8b4885e4879c7662e
https://github.com/pencil-code/pencil-code/commit/076ba18cb4c054a9970353b8b4885e4879c7662e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: rm unused variable ptlaw
Commit: 9a373c855bb33ba038ef28a6841fecdcb8f42c00
https://github.com/pencil-code/pencil-code/commit/9a373c855bb33ba038ef28a6841fecdcb8f42c00
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: rm misleading svnid
Commit: b187fa10e1d1a463302c598defb4532fb9abc89f
https://github.com/pencil-code/pencil-code/commit/b187fa10e1d1a463302c598defb4532fb9abc89f
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: fix error message
Commit: a59348cd5ca21f0657ce7c12382beb2663c1f27f
https://github.com/pencil-code/pencil-code/commit/a59348cd5ca21f0657ce7c12382beb2663c1f27f
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: get reference state if needed
Commit: 9a528cab31d6d28b0af249cb0ede3b6b680a6420
https://github.com/pencil-code/pencil-code/commit/9a528cab31d6d28b0af249cb0ede3b6b680a6420
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos_idealgas.f90
Log Message:
-----------
eos_idealgas/bc_ss_temp_z: comment
Commit: 1be29129c31eb3822fe16119d309bce66fd32fbd
https://github.com/pencil-code/pencil-code/commit/1be29129c31eb3822fe16119d309bce66fd32fbd
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/units_eos: fix subroutine name in output
Commit: f2c1c38c2c80f95214a1620142d5cdc9869dd3f7
https://github.com/pencil-code/pencil-code/commit/f2c1c38c2c80f95214a1620142d5cdc9869dd3f7
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: implement bc_ss_temp_z
Copied from eos_idealgas, but with some modifications to work here.
Commit: 43c5ab7f4580faf9f82f492bef74a65769eddd8e
https://github.com/pencil-code/pencil-code/commit/43c5ab7f4580faf9f82f492bef74a65769eddd8e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_temp_z: rm empty line
Commit: 1df4dcea9941dc787c4c317a4561283855e813c7
https://github.com/pencil-code/pencil-code/commit/1df4dcea9941dc787c4c317a4561283855e813c7
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos_idealgas.f90
Log Message:
-----------
eos_idealgas/bc_ss_temp_z: remove l2nd=.true. from the set_ghosts_for_onesided_ders calls
Verified that fradz_Kprof is now constant in the steady state of a 1D
thermal conduction problem.
Matthias, do you remember why you initially set this to .true.? From
set_ghosts_for_onesided_ders, it looks like the only effect of setting
it to .true. is to leave one of the ghost points unset, but am I missing
something?
Commit: 6bfcce780695055c07f9d2ceac3d4ca496d7edce
https://github.com/pencil-code/pencil-code/commit/6bfcce780695055c07f9d2ceac3d4ca496d7edce
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_temp_z: fix silly indexing mistake.
I'm starting to think I should not be allowed near computers at all.
Commit: e91179cad0cf7c6da77826f4fa6e8b5fe7147114
https://github.com/pencil-code/pencil-code/commit/e91179cad0cf7c6da77826f4fa6e8b5fe7147114
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_temp_z: remove l2nd=.true. from the set_ghosts_for_onesided_ders calls
Recently made the same change in eos_idealgas.f90
Commit: d34f83bb008e81d9827e045b33d40ab9892a6e8e
https://github.com/pencil-code/pencil-code/commit/d34f83bb008e81d9827e045b33d40ab9892a6e8e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/start.f90
Log Message:
-----------
start.f90: move init_eos into the init_loops loop
The issue I am trying to deal with is: in eos_idealgas_vapor, cp is not
a constant (calculated based on the value of another variable), and so
is stored in the f-array. If any initial condition wants to use this
non-constant cp, it needs to have the cp already present in the f-array.
The only idea I have right now is to populate the f array in init_eos,
and then use init_loops=2 so that the correct value of cp will be picked
up on the second run.
This is of course a dirty hack, so better suggestions are welcome.
Commit: 1d14b804031c4eb5350865d1193768c1034a52f7
https://github.com/pencil-code/pencil-code/commit/1d14b804031c4eb5350865d1193768c1034a52f7
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: add init_eos
Commit: a312f014d65c847dafdd8a5d8dd74db3e5d068c5
https://github.com/pencil-code/pencil-code/commit/a312f014d65c847dafdd8a5d8dd74db3e5d068c5
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/initialize_eos: sane placeholder values for uninitialized f-array variables
This is needed because currently init_eos is called after, e.g.
init_lnrho. Initial conditions in init_lnrho may want to get the value
of cp using get_gamma_etc. These placeholder values ensure that they at
least get sane values rather than 0 or impossible. To actually use the
correct value of cp in the initial conditions, one needs to set
init_loops=2
Commit: 600565218441055e539b8e868cdcefa7c705c20e
https://github.com/pencil-code/pencil-code/commit/600565218441055e539b8e868cdcefa7c705c20e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: add eos-agnostic implementation of bc_ss_flux
May move to entropy.f90 or boundcond.f90 after testing.
Took the oppurtunity to reduce code duplication between the top and
bottom cases.
Commit: 9c05a955f52b310de874227a03bac2eb49c22c32
https://github.com/pencil-code/pencil-code/commit/9c05a955f52b310de874227a03bac2eb49c22c32
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos.h
M src/noeos.f90
Log Message:
-----------
eos.h: add eoscalc_point_f to interface
Calculates EOS variables given the f-array at a single spatial point.
eoscalc_point seems impossible to implement for eos_idealgas_vapor,
since the temperature etc. depend on components of the f-array that are
not present in eosvar{1,2}
For EOS modules which implement eoscalc_point, eoscalc_point_f is just a
wrapper around that.
Commit: 7c21edbc12f1e93c350a8fd8e7f40fd6f4773f9e
https://github.com/pencil-code/pencil-code/commit/7c21edbc12f1e93c350a8fd8e7f40fd6f4773f9e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: Implement eoscalc_point_f
Commit: 5d1f003933b14a8e23029d6ff351ff16cb9f4721
https://github.com/pencil-code/pencil-code/commit/5d1f003933b14a8e23029d6ff351ff16cb9f4721
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: fix use of eoscalc
eoscalc_point is not implemented, so use eoscalc_point_f
Commit: eef2a1765018da106c759d7c29c597a8169f316b
https://github.com/pencil-code/pencil-code/commit/eef2a1765018da106c759d7c29c597a8169f316b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos_idealgas.f90
M src/noeos.f90
Log Message:
-----------
noeos/eoscalc_point_f: call not_implemented
The wrapper implementation is now moved to eos_idealgas. Apparently not
all EOS modules have ieosvar{1,2} defined.
Commit: c41e1f78a502798704b5b492ace989bf934aa41c
https://github.com/pencil-code/pencil-code/commit/c41e1f78a502798704b5b492ace989bf934aa41c
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/eoscalc_point_f: use gamma_m1
Commit: bd252e1e4083138f6a80188b8289e5fa06295cc8
https://github.com/pencil-code/pencil-code/commit/bd252e1e4083138f6a80188b8289e5fa06295cc8
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/eoscalc_point_f: use gamma1
Commit: e6b95b05a3be58c1f9cebb3fb7f3e4f75a9c5396
https://github.com/pencil-code/pencil-code/commit/e6b95b05a3be58c1f9cebb3fb7f3e4f75a9c5396
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: refactor
Make the code correspond to TOP to assist debugging a problem
Commit: 699659f79f1f780867a612f3c6afed4b40add045
https://github.com/pencil-code/pencil-code/commit/699659f79f1f780867a612f3c6afed4b40add045
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: rename variable
Commit: 2ecd3cb00906cfa9d2f504fa5dd7b7f2a4eaae9e
https://github.com/pencil-code/pencil-code/commit/2ecd3cb00906cfa9d2f504fa5dd7b7f2a4eaae9e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: rm unused block
Commit: b00abe67daf7f597277a97425853250746d432a6
https://github.com/pencil-code/pencil-code/commit/b00abe67daf7f597277a97425853250746d432a6
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: write in terms of temperature rather than sound speed
Commit: 29a4dfa9dbbe77ae7c5ddd7757594a492c6966bd
https://github.com/pencil-code/pencil-code/commit/29a4dfa9dbbe77ae7c5ddd7757594a492c6966bd
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor:/bc_ss_flux: remove final EOS-dependence
p/(rho*T) is not always (cp-cv)
Commit: 8de716e06955999430d8af2a1c5c375da8b88a25
https://github.com/pencil-code/pencil-code/commit/8de716e06955999430d8af2a1c5c375da8b88a25
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: more explicit name for a variable
Commit: 662b4693265c2ffe075ffa049a1c67a00022a135
https://github.com/pencil-code/pencil-code/commit/662b4693265c2ffe075ffa049a1c67a00022a135
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: reuse variable
Commit: 0c304d5fd9c60c81b40971133632a4081d618c0a
https://github.com/pencil-code/pencil-code/commit/0c304d5fd9c60c81b40971133632a4081d618c0a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: rm/update comments
Commit: 82e411cdefacc788de3aa39785377d558084493e
https://github.com/pencil-code/pencil-code/commit/82e411cdefacc788de3aa39785377d558084493e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: restore lpretend_lnTT block
I was wrong. I think this implementation should work, but I have not
tested it
Commit: 4a861448684811e3b295a6804562e90d7445731f
https://github.com/pencil-code/pencil-code/commit/4a861448684811e3b295a6804562e90d7445731f
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: better handling of different thermal conductivities
Commit: ea469e9e8ed6194d3b68acf5c2a05057822ce8bb
https://github.com/pencil-code/pencil-code/commit/ea469e9e8ed6194d3b68acf5c2a05057822ce8bb
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: comments
Commit: b67b51a2e40e0c323faebff79963076d410c9598
https://github.com/pencil-code/pencil-code/commit/b67b51a2e40e0c323faebff79963076d410c9598
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: fix apparently missing factor of cp
Commit: ee3879d318a6b1e3776a2f77794f7af0b3def415
https://github.com/pencil-code/pencil-code/commit/ee3879d318a6b1e3776a2f77794f7af0b3def415
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/eoscalc_point_f: comment
Commit: fc277393ca6f02deb5c62172134625863df12925
https://github.com/pencil-code/pencil-code/commit/fc277393ca6f02deb5c62172134625863df12925
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/eoscalc_point_f: add not_implemented calls
Commit: e6f1ebc24b53ea215101ffe00fdcf7c859158c2c
https://github.com/pencil-code/pencil-code/commit/e6f1ebc24b53ea215101ffe00fdcf7c859158c2c
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos_chemistry_simple.f90
M src/eos_fixed_ionization.f90
M src/eos_idealgas.f90
M src/eos_ionization.f90
M src/eos_temperature_ionization.f90
M src/experimental/test_eos_chemistry.f90
M src/noeos.f90
Log Message:
-----------
eos_*/get_gamma_etc: add optional argument
To match call signature of eos_idealgas_vapor/get_gamma_etc
The new argument is the f-array at the spatial point where one wants the
values of cp, cv, gamma (f(il,im,in,:)). I *think* this should be enough
to accommodate all the EOS we currently have.
Commit: ae05e1795af865b386d423c686e81ec21a9492d8
https://github.com/pencil-code/pencil-code/commit/ae05e1795af865b386d423c686e81ec21a9492d8
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
M src/noeos.f90
Log Message:
-----------
bc_ss_flux: move EOS-agnostic implementation to noeos.f90
If it indeed works for all EOS, it can later be moved to entropy.f90.
Copied over the history from eos_idealgas.f90
Commit: a15cdf1026db600c18bbd1048e22fee993f52906
https://github.com/pencil-code/pencil-code/commit/a15cdf1026db600c18bbd1048e22fee993f52906
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/noeos.f90
Log Message:
-----------
noeos/bc_ss_flux: fix segfault
During start, none of the heat conduction options are actually set, and
so the code tries to access FbyK. Ensure that this is initialized by
default.
Commit: ed661e4d352a00ec829d8186d6024927d817a19c
https://github.com/pencil-code/pencil-code/commit/ed661e4d352a00ec829d8186d6024927d817a19c
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos_idealgas.f90
Log Message:
-----------
eos_idealgas.f90: remove bc_ss_flux
Use the implementation in noeos.f90.
Commit: 3dfa84b5c0d9ec2655e3b315504cca2fbd6f6c99
https://github.com/pencil-code/pencil-code/commit/3dfa84b5c0d9ec2655e3b315504cca2fbd6f6c99
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M python/tests/manual.py
Log Message:
-----------
Python: tests/manual.py: update reference values for test_read_var
Necessitated by my recent replacement of eos_idealgas.f90/bc_ss_flux by
noeos.f90/bc_ss_flux. Although my change did not cause the auto-test to
fail, this Python test validates values to a higher precision. For
example, the test `np.mean(f[1, :, :, :])` was being tested to a
precision of 1e-17 (!).
I have checked that if the grid size is changed to 64^3 (from 32^3, and
reference values are changed accordingly), the replacement of the
boundary condition does not cause the Python test to fail (excepting the
one that was being tested to precision 1e-17, which did not converge
even with a 128^3 grid). Nevertheless, I have not changed the grid size
of the sample.
Commit: 880a06e5b21d4fa52a3410225196a61acecfeedc
https://github.com/pencil-code/pencil-code/commit/880a06e5b21d4fa52a3410225196a61acecfeedc
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/noeos.f90
Log Message:
-----------
noeos/bc_ss_flux: add TODO
Commit: 78a971be5625c386360889c43aeddaf3c3d23525
https://github.com/pencil-code/pencil-code/commit/78a971be5625c386360889c43aeddaf3c3d23525
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/ascalar.f90
Log Message:
-----------
ascalar: add diagnostic: accmz
Horizontal average of the scalar
Commit: 026dcc294588940fc1a678bf2abfb04e1d8f364f
https://github.com/pencil-code/pencil-code/commit/026dcc294588940fc1a678bf2abfb04e1d8f364f
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/ascalar.f90
Log Message:
-----------
ascalar: add an initial condition
Commit: 8cef2414ffdcdb28b8c65b46b935d7d33285058b
https://github.com/pencil-code/pencil-code/commit/8cef2414ffdcdb28b8c65b46b935d7d33285058b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/ascalar.f90
Log Message:
-----------
ascalar: add parameter for initial condition tanhz
To control its location
Commit: e9d46caf265b6944322d206c5bca37198c9a9f0a
https://github.com/pencil-code/pencil-code/commit/e9d46caf265b6944322d206c5bca37198c9a9f0a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: move register_report_aux to register_eos
We do not want to do this during RELOAD as well
Commit: af145898cd0d321591f546007e6f9545b9d2f570
https://github.com/pencil-code/pencil-code/commit/af145898cd0d321591f546007e6f9545b9d2f570
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/initialize_eos: don't zero out aux array during RELOAD
Is this the recommended way?
Commit: db2af5b261269f1e798abb1ae9073708f484f54a
https://github.com/pencil-code/pencil-code/commit/db2af5b261269f1e798abb1ae9073708f484f54a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/entropy.f90
Log Message:
-----------
entropy.f90/denergy_dt: fix mistake in comment
Compare: https://github.com/pencil-code/pencil-code/compare/5d98b77ee31c...db2af5b26126
To unsubscribe from these emails, change your notification settings at https://github.com/pencil-code/pencil-code/settings/notifications
Home: https://github.com/pencil-code/pencil-code
Commit: 962fea3624f66b9a1737357df29e870e4d5cbc8a
https://github.com/pencil-code/pencil-code/commit/962fea3624f66b9a1737357df29e870e4d5cbc8a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: get_gamma_etc: gamma is actually a constant in this module
Commit: 306d4df04acb528f29c35dfae5720b0ef0480f0a
https://github.com/pencil-code/pencil-code/commit/306d4df04acb528f29c35dfae5720b0ef0480f0a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: option to have cp as auxiliary variable
Commit: 050b00fd4f50cb5c86ad7f5309292f92b8f5c080
https://github.com/pencil-code/pencil-code/commit/050b00fd4f50cb5c86ad7f5309292f92b8f5c080
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: move pencils for aux to pencil_criteria_eos
Commit: 36b6b24b5e04beb31f8ee186932ec6f9a56e94ac
https://github.com/pencil-code/pencil-code/commit/36b6b24b5e04beb31f8ee186932ec6f9a56e94ac
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/get_gamma_etc: add f-array as an optional argument
So that cp can be obtained from it when lcp_as_aux=T. I think that for
other eos modules too, having the f-array would allow cp etc to be
calculated correctly within the get_gamma_etc subroutine.
Commit: 5fa0f7fd6032e1a65e6af750d6399c4997b78c4b
https://github.com/pencil-code/pencil-code/commit/5fa0f7fd6032e1a65e6af750d6399c4997b78c4b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: add some cparam declarations
Unclear why we say leos_idealgas=.true.
Commit: 323fb444dd8660e8f3697668f1edd05110219213
https://github.com/pencil-code/pencil-code/commit/323fb444dd8660e8f3697668f1edd05110219213
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: Implement bc_lnrho_temp_z
Commit: 95dc5664b30a0981630544eae5eddbe0b4e00060
https://github.com/pencil-code/pencil-code/commit/95dc5664b30a0981630544eae5eddbe0b4e00060
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: rm unused variable
Clashes with something in cdata
Commit: 8c53b37f7a6919b34384772b042faff902b20614
https://github.com/pencil-code/pencil-code/commit/8c53b37f7a6919b34384772b042faff902b20614
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: include dummy routines
Commit: 3d378820bcf4eff0a5618f7b1c1831f6c8520dfd
https://github.com/pencil-code/pencil-code/commit/3d378820bcf4eff0a5618f7b1c1831f6c8520dfd
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: correctly calculate vapour fraction
Have added a new pencil, fvap.
Axel, in commit e495afe2fecd170243aa475024da0f3f5b3fd632 ,
you made a change to treat p%ssat as the vapour fraction.
However, I think that should be calculated as in this commit.
Do you agree? I do not see eos_idealgas_vapor being used
in any samples, and so have taken the liberty of changing it.
Commit: 5c8c380fd78d47e2f1f4d9607234e54d08438b4b
https://github.com/pencil-code/pencil-code/commit/5c8c380fd78d47e2f1f4d9607234e54d08438b4b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/calc_pencils_eos_pencpar: intent inout for f array
Just as in eos_idealgas; needed when lcp_as_aux=T
Commit: 6fa2462497dcc72f13f7949b5323d298c87141c3
https://github.com/pencil-code/pencil-code/commit/6fa2462497dcc72f13f7949b5323d298c87141c3
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/calc_pencils_eos_pencpar: rm unused variable
Commit: 727fc518086c07b7978020f1adce090cde93ae5f
https://github.com/pencil-code/pencil-code/commit/727fc518086c07b7978020f1adce090cde93ae5f
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: include eos_params.h
Commit: 328bdd9667e75eb209c53acdd338b3ca859f5718
https://github.com/pencil-code/pencil-code/commit/328bdd9667e75eb209c53acdd338b3ca859f5718
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: update type of topbot for bc functions
Commit: dd3f2f05c8fab1982e6e953412601c1679a7207b
https://github.com/pencil-code/pencil-code/commit/dd3f2f05c8fab1982e6e953412601c1679a7207b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: add required public stuff
Commit: 2e3bd7c413eed5156d53be9ba6df1a88a10beb44
https://github.com/pencil-code/pencil-code/commit/2e3bd7c413eed5156d53be9ba6df1a88a10beb44
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: remove reference state stuff
Pretty sure it needs to be accounted for in other places too
Commit: 7859d09b6c4f80baba8f40d534c74d76a1c95c73
https://github.com/pencil-code/pencil-code/commit/7859d09b6c4f80baba8f40d534c74d76a1c95c73
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: move to be with other BCs
Still in the same file
Commit: 78ed1acafec99137d2c6b383db0b11732e23983e
https://github.com/pencil-code/pencil-code/commit/78ed1acafec99137d2c6b383db0b11732e23983e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/isothermal_entropy: update call signature
Copied from noeos
Commit: 4a4b5e765b2f6075194a04c3de9046970aea2644
https://github.com/pencil-code/pencil-code/commit/4a4b5e765b2f6075194a04c3de9046970aea2644
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/noeos.f90
Log Message:
-----------
noeos: add fatal error for unimplemented BCs
Commit: b256b72eb537a0f539cbce3de020d2938525e9e6
https://github.com/pencil-code/pencil-code/commit/b256b72eb537a0f539cbce3de020d2938525e9e6
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: rm unimplemented functions
eos_dummies already provides dummy implementations
Commit: 72932a067b1d82e7648ddba7db4e485a56d5ae0a
https://github.com/pencil-code/pencil-code/commit/72932a067b1d82e7648ddba7db4e485a56d5ae0a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: fatal error for unimplemented BCs
Commit: f519d01f08d559ab557a1600fdb3f72d51c2abc6
https://github.com/pencil-code/pencil-code/commit/f519d01f08d559ab557a1600fdb3f72d51c2abc6
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/initialize_eos: update call signature
Commit: 049f5b7581170c4008bb83f525b6fa1ee75c8eaf
https://github.com/pencil-code/pencil-code/commit/049f5b7581170c4008bb83f525b6fa1ee75c8eaf
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: add use statements
Compiles now
Commit: b06914b537c6d16baea619db6b36870eb1507d54
https://github.com/pencil-code/pencil-code/commit/b06914b537c6d16baea619db6b36870eb1507d54
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: put some shared variables
I think these guys are only used in density.f90 for the polytropic ICs
Commit: 7ae0ecf8a7ec161b3e9ab4c7f4ea6e9def0ccb49
https://github.com/pencil-code/pencil-code/commit/7ae0ecf8a7ec161b3e9ab4c7f4ea6e9def0ccb49
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: stricter argument declarations
Commit: 6fc0d2a006ae332a839b03f09d1c90713fbe0242
https://github.com/pencil-code/pencil-code/commit/6fc0d2a006ae332a839b03f09d1c90713fbe0242
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/get_gamma_etc: check that cp is not zero
For some reason, it ends up being zero even outside the ghost zones
Commit: 1967e038151412cc26c70352ac5c85a6a37899c5
https://github.com/pencil-code/pencil-code/commit/1967e038151412cc26c70352ac5c85a6a37899c5
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos.h
M src/equ.f90
M src/noeos.f90
Log Message:
-----------
Add eos_before_boundary subroutine
Only a dummy implementation in noeos for now.
Commit: 9be11a8a7be1c63cbf67e706445a6e8582b9609d
https://github.com/pencil-code/pencil-code/commit/9be11a8a7be1c63cbf67e706445a6e8582b9609d
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/cdata.f90
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: calculate cp etc in eos_before_boundary subroutine
Subroutine get_gamma_etc requires cp to be in the f-array. Usage of
get_gamma_etc in boundary condition routines then requires that cp be
present in the f-array before the boundary conditions are called.
Calculating cp requires fvap and mumol1; we then keep them in the
f-array
to avoid unnecessary recomputation if these are needed as pencils later
on.
Commit: 03ec91c3a9bd8879d075a96a408e8ca496ae54d7
https://github.com/pencil-code/pencil-code/commit/03ec91c3a9bd8879d075a96a408e8ca496ae54d7
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: use mx,my directly for index ranges
Commit: 0e992ba40c9c3038772b06f2b986eb33e573f0dd
https://github.com/pencil-code/pencil-code/commit/0e992ba40c9c3038772b06f2b986eb33e573f0dd
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/cdata.f90
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: remove indices for aux from cdata
I don't see any need right now for these to be globally available. They
can be moved to cdata later if it turns out another module needs them.
Commit: e31b5ea08c72c655b7ab3b7eb8b12073a02129f6
https://github.com/pencil-code/pencil-code/commit/e31b5ea08c72c655b7ab3b7eb8b12073a02129f6
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/get_gamma_etc: better fallback value for cv
Commit: a529664fb6d1085a5257419c70e452723a4713ed
https://github.com/pencil-code/pencil-code/commit/a529664fb6d1085a5257419c70e452723a4713ed
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/units_eos: do not reset lnTT0 to 0
Unclear why this was ever done. Ugh.
Commit: 4a43e5bacd59e0f5cce44137f55a1a08c43cc9eb
https://github.com/pencil-code/pencil-code/commit/4a43e5bacd59e0f5cce44137f55a1a08c43cc9eb
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: use gamma_m1 rather than gamma-1
Commit: 46596c0cba882839291f54165c69133e0b4e568d
https://github.com/pencil-code/pencil-code/commit/46596c0cba882839291f54165c69133e0b4e568d
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: fix sign mistake
Commit: 7eae299d92ed46052d7fa343db8f7f8fe7113071
https://github.com/pencil-code/pencil-code/commit/7eae299d92ed46052d7fa343db8f7f8fe7113071
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor.f90: remove dummy get_stratz
Will be included from noeos
Commit: 492cd438fee973d9f70ac3414453e78be0e08309
https://github.com/pencil-code/pencil-code/commit/492cd438fee973d9f70ac3414453e78be0e08309
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: remove dummy routines
These routines do not even raise an error, which does not seem right.
Commit: ba17c93fa95be77f31f799e50e3cd3cf58d42f1b
https://github.com/pencil-code/pencil-code/commit/ba17c93fa95be77f31f799e50e3cd3cf58d42f1b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: rm subroutine get_ptlaw which is no longer used anywhere
Commit: 076ba18cb4c054a9970353b8b4885e4879c7662e
https://github.com/pencil-code/pencil-code/commit/076ba18cb4c054a9970353b8b4885e4879c7662e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: rm unused variable ptlaw
Commit: 9a373c855bb33ba038ef28a6841fecdcb8f42c00
https://github.com/pencil-code/pencil-code/commit/9a373c855bb33ba038ef28a6841fecdcb8f42c00
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: rm misleading svnid
Commit: b187fa10e1d1a463302c598defb4532fb9abc89f
https://github.com/pencil-code/pencil-code/commit/b187fa10e1d1a463302c598defb4532fb9abc89f
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_lnrho_temp_z: fix error message
Commit: a59348cd5ca21f0657ce7c12382beb2663c1f27f
https://github.com/pencil-code/pencil-code/commit/a59348cd5ca21f0657ce7c12382beb2663c1f27f
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: get reference state if needed
Commit: 9a528cab31d6d28b0af249cb0ede3b6b680a6420
https://github.com/pencil-code/pencil-code/commit/9a528cab31d6d28b0af249cb0ede3b6b680a6420
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos_idealgas.f90
Log Message:
-----------
eos_idealgas/bc_ss_temp_z: comment
Commit: 1be29129c31eb3822fe16119d309bce66fd32fbd
https://github.com/pencil-code/pencil-code/commit/1be29129c31eb3822fe16119d309bce66fd32fbd
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/units_eos: fix subroutine name in output
Commit: f2c1c38c2c80f95214a1620142d5cdc9869dd3f7
https://github.com/pencil-code/pencil-code/commit/f2c1c38c2c80f95214a1620142d5cdc9869dd3f7
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: implement bc_ss_temp_z
Copied from eos_idealgas, but with some modifications to work here.
Commit: 43c5ab7f4580faf9f82f492bef74a65769eddd8e
https://github.com/pencil-code/pencil-code/commit/43c5ab7f4580faf9f82f492bef74a65769eddd8e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_temp_z: rm empty line
Commit: 1df4dcea9941dc787c4c317a4561283855e813c7
https://github.com/pencil-code/pencil-code/commit/1df4dcea9941dc787c4c317a4561283855e813c7
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos_idealgas.f90
Log Message:
-----------
eos_idealgas/bc_ss_temp_z: remove l2nd=.true. from the set_ghosts_for_onesided_ders calls
Verified that fradz_Kprof is now constant in the steady state of a 1D
thermal conduction problem.
Matthias, do you remember why you initially set this to .true.? From
set_ghosts_for_onesided_ders, it looks like the only effect of setting
it to .true. is to leave one of the ghost points unset, but am I missing
something?
Commit: 6bfcce780695055c07f9d2ceac3d4ca496d7edce
https://github.com/pencil-code/pencil-code/commit/6bfcce780695055c07f9d2ceac3d4ca496d7edce
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_temp_z: fix silly indexing mistake.
I'm starting to think I should not be allowed near computers at all.
Commit: e91179cad0cf7c6da77826f4fa6e8b5fe7147114
https://github.com/pencil-code/pencil-code/commit/e91179cad0cf7c6da77826f4fa6e8b5fe7147114
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_temp_z: remove l2nd=.true. from the set_ghosts_for_onesided_ders calls
Recently made the same change in eos_idealgas.f90
Commit: d34f83bb008e81d9827e045b33d40ab9892a6e8e
https://github.com/pencil-code/pencil-code/commit/d34f83bb008e81d9827e045b33d40ab9892a6e8e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/start.f90
Log Message:
-----------
start.f90: move init_eos into the init_loops loop
The issue I am trying to deal with is: in eos_idealgas_vapor, cp is not
a constant (calculated based on the value of another variable), and so
is stored in the f-array. If any initial condition wants to use this
non-constant cp, it needs to have the cp already present in the f-array.
The only idea I have right now is to populate the f array in init_eos,
and then use init_loops=2 so that the correct value of cp will be picked
up on the second run.
This is of course a dirty hack, so better suggestions are welcome.
Commit: 1d14b804031c4eb5350865d1193768c1034a52f7
https://github.com/pencil-code/pencil-code/commit/1d14b804031c4eb5350865d1193768c1034a52f7
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: add init_eos
Commit: a312f014d65c847dafdd8a5d8dd74db3e5d068c5
https://github.com/pencil-code/pencil-code/commit/a312f014d65c847dafdd8a5d8dd74db3e5d068c5
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/initialize_eos: sane placeholder values for uninitialized f-array variables
This is needed because currently init_eos is called after, e.g.
init_lnrho. Initial conditions in init_lnrho may want to get the value
of cp using get_gamma_etc. These placeholder values ensure that they at
least get sane values rather than 0 or impossible. To actually use the
correct value of cp in the initial conditions, one needs to set
init_loops=2
Commit: 600565218441055e539b8e868cdcefa7c705c20e
https://github.com/pencil-code/pencil-code/commit/600565218441055e539b8e868cdcefa7c705c20e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: add eos-agnostic implementation of bc_ss_flux
May move to entropy.f90 or boundcond.f90 after testing.
Took the oppurtunity to reduce code duplication between the top and
bottom cases.
Commit: 9c05a955f52b310de874227a03bac2eb49c22c32
https://github.com/pencil-code/pencil-code/commit/9c05a955f52b310de874227a03bac2eb49c22c32
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos.h
M src/noeos.f90
Log Message:
-----------
eos.h: add eoscalc_point_f to interface
Calculates EOS variables given the f-array at a single spatial point.
eoscalc_point seems impossible to implement for eos_idealgas_vapor,
since the temperature etc. depend on components of the f-array that are
not present in eosvar{1,2}
For EOS modules which implement eoscalc_point, eoscalc_point_f is just a
wrapper around that.
Commit: 7c21edbc12f1e93c350a8fd8e7f40fd6f4773f9e
https://github.com/pencil-code/pencil-code/commit/7c21edbc12f1e93c350a8fd8e7f40fd6f4773f9e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: Implement eoscalc_point_f
Commit: 5d1f003933b14a8e23029d6ff351ff16cb9f4721
https://github.com/pencil-code/pencil-code/commit/5d1f003933b14a8e23029d6ff351ff16cb9f4721
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: fix use of eoscalc
eoscalc_point is not implemented, so use eoscalc_point_f
Commit: eef2a1765018da106c759d7c29c597a8169f316b
https://github.com/pencil-code/pencil-code/commit/eef2a1765018da106c759d7c29c597a8169f316b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos_idealgas.f90
M src/noeos.f90
Log Message:
-----------
noeos/eoscalc_point_f: call not_implemented
The wrapper implementation is now moved to eos_idealgas. Apparently not
all EOS modules have ieosvar{1,2} defined.
Commit: c41e1f78a502798704b5b492ace989bf934aa41c
https://github.com/pencil-code/pencil-code/commit/c41e1f78a502798704b5b492ace989bf934aa41c
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/eoscalc_point_f: use gamma_m1
Commit: bd252e1e4083138f6a80188b8289e5fa06295cc8
https://github.com/pencil-code/pencil-code/commit/bd252e1e4083138f6a80188b8289e5fa06295cc8
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/eoscalc_point_f: use gamma1
Commit: e6b95b05a3be58c1f9cebb3fb7f3e4f75a9c5396
https://github.com/pencil-code/pencil-code/commit/e6b95b05a3be58c1f9cebb3fb7f3e4f75a9c5396
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: refactor
Make the code correspond to TOP to assist debugging a problem
Commit: 699659f79f1f780867a612f3c6afed4b40add045
https://github.com/pencil-code/pencil-code/commit/699659f79f1f780867a612f3c6afed4b40add045
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: rename variable
Commit: 2ecd3cb00906cfa9d2f504fa5dd7b7f2a4eaae9e
https://github.com/pencil-code/pencil-code/commit/2ecd3cb00906cfa9d2f504fa5dd7b7f2a4eaae9e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: rm unused block
Commit: b00abe67daf7f597277a97425853250746d432a6
https://github.com/pencil-code/pencil-code/commit/b00abe67daf7f597277a97425853250746d432a6
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: write in terms of temperature rather than sound speed
Commit: 29a4dfa9dbbe77ae7c5ddd7757594a492c6966bd
https://github.com/pencil-code/pencil-code/commit/29a4dfa9dbbe77ae7c5ddd7757594a492c6966bd
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor:/bc_ss_flux: remove final EOS-dependence
p/(rho*T) is not always (cp-cv)
Commit: 8de716e06955999430d8af2a1c5c375da8b88a25
https://github.com/pencil-code/pencil-code/commit/8de716e06955999430d8af2a1c5c375da8b88a25
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: more explicit name for a variable
Commit: 662b4693265c2ffe075ffa049a1c67a00022a135
https://github.com/pencil-code/pencil-code/commit/662b4693265c2ffe075ffa049a1c67a00022a135
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: reuse variable
Commit: 0c304d5fd9c60c81b40971133632a4081d618c0a
https://github.com/pencil-code/pencil-code/commit/0c304d5fd9c60c81b40971133632a4081d618c0a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: rm/update comments
Commit: 82e411cdefacc788de3aa39785377d558084493e
https://github.com/pencil-code/pencil-code/commit/82e411cdefacc788de3aa39785377d558084493e
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: restore lpretend_lnTT block
I was wrong. I think this implementation should work, but I have not
tested it
Commit: 4a861448684811e3b295a6804562e90d7445731f
https://github.com/pencil-code/pencil-code/commit/4a861448684811e3b295a6804562e90d7445731f
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: better handling of different thermal conductivities
Commit: ea469e9e8ed6194d3b68acf5c2a05057822ce8bb
https://github.com/pencil-code/pencil-code/commit/ea469e9e8ed6194d3b68acf5c2a05057822ce8bb
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: comments
Commit: b67b51a2e40e0c323faebff79963076d410c9598
https://github.com/pencil-code/pencil-code/commit/b67b51a2e40e0c323faebff79963076d410c9598
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/bc_ss_flux: fix apparently missing factor of cp
Commit: ee3879d318a6b1e3776a2f77794f7af0b3def415
https://github.com/pencil-code/pencil-code/commit/ee3879d318a6b1e3776a2f77794f7af0b3def415
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/eoscalc_point_f: comment
Commit: fc277393ca6f02deb5c62172134625863df12925
https://github.com/pencil-code/pencil-code/commit/fc277393ca6f02deb5c62172134625863df12925
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/eoscalc_point_f: add not_implemented calls
Commit: e6f1ebc24b53ea215101ffe00fdcf7c859158c2c
https://github.com/pencil-code/pencil-code/commit/e6f1ebc24b53ea215101ffe00fdcf7c859158c2c
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos_chemistry_simple.f90
M src/eos_fixed_ionization.f90
M src/eos_idealgas.f90
M src/eos_ionization.f90
M src/eos_temperature_ionization.f90
M src/experimental/test_eos_chemistry.f90
M src/noeos.f90
Log Message:
-----------
eos_*/get_gamma_etc: add optional argument
To match call signature of eos_idealgas_vapor/get_gamma_etc
The new argument is the f-array at the spatial point where one wants the
values of cp, cv, gamma (f(il,im,in,:)). I *think* this should be enough
to accommodate all the EOS we currently have.
Commit: ae05e1795af865b386d423c686e81ec21a9492d8
https://github.com/pencil-code/pencil-code/commit/ae05e1795af865b386d423c686e81ec21a9492d8
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
M src/noeos.f90
Log Message:
-----------
bc_ss_flux: move EOS-agnostic implementation to noeos.f90
If it indeed works for all EOS, it can later be moved to entropy.f90.
Copied over the history from eos_idealgas.f90
Commit: a15cdf1026db600c18bbd1048e22fee993f52906
https://github.com/pencil-code/pencil-code/commit/a15cdf1026db600c18bbd1048e22fee993f52906
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/noeos.f90
Log Message:
-----------
noeos/bc_ss_flux: fix segfault
During start, none of the heat conduction options are actually set, and
so the code tries to access FbyK. Ensure that this is initialized by
default.
Commit: ed661e4d352a00ec829d8186d6024927d817a19c
https://github.com/pencil-code/pencil-code/commit/ed661e4d352a00ec829d8186d6024927d817a19c
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/eos_idealgas.f90
Log Message:
-----------
eos_idealgas.f90: remove bc_ss_flux
Use the implementation in noeos.f90.
Commit: 3dfa84b5c0d9ec2655e3b315504cca2fbd6f6c99
https://github.com/pencil-code/pencil-code/commit/3dfa84b5c0d9ec2655e3b315504cca2fbd6f6c99
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M python/tests/manual.py
Log Message:
-----------
Python: tests/manual.py: update reference values for test_read_var
Necessitated by my recent replacement of eos_idealgas.f90/bc_ss_flux by
noeos.f90/bc_ss_flux. Although my change did not cause the auto-test to
fail, this Python test validates values to a higher precision. For
example, the test `np.mean(f[1, :, :, :])` was being tested to a
precision of 1e-17 (!).
I have checked that if the grid size is changed to 64^3 (from 32^3, and
reference values are changed accordingly), the replacement of the
boundary condition does not cause the Python test to fail (excepting the
one that was being tested to precision 1e-17, which did not converge
even with a 128^3 grid). Nevertheless, I have not changed the grid size
of the sample.
Commit: 880a06e5b21d4fa52a3410225196a61acecfeedc
https://github.com/pencil-code/pencil-code/commit/880a06e5b21d4fa52a3410225196a61acecfeedc
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/noeos.f90
Log Message:
-----------
noeos/bc_ss_flux: add TODO
Commit: 78a971be5625c386360889c43aeddaf3c3d23525
https://github.com/pencil-code/pencil-code/commit/78a971be5625c386360889c43aeddaf3c3d23525
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/ascalar.f90
Log Message:
-----------
ascalar: add diagnostic: accmz
Horizontal average of the scalar
Commit: 026dcc294588940fc1a678bf2abfb04e1d8f364f
https://github.com/pencil-code/pencil-code/commit/026dcc294588940fc1a678bf2abfb04e1d8f364f
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/ascalar.f90
Log Message:
-----------
ascalar: add an initial condition
Commit: 8cef2414ffdcdb28b8c65b46b935d7d33285058b
https://github.com/pencil-code/pencil-code/commit/8cef2414ffdcdb28b8c65b46b935d7d33285058b
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/ascalar.f90
Log Message:
-----------
ascalar: add parameter for initial condition tanhz
To control its location
Commit: e9d46caf265b6944322d206c5bca37198c9a9f0a
https://github.com/pencil-code/pencil-code/commit/e9d46caf265b6944322d206c5bca37198c9a9f0a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor: move register_report_aux to register_eos
We do not want to do this during RELOAD as well
Commit: af145898cd0d321591f546007e6f9545b9d2f570
https://github.com/pencil-code/pencil-code/commit/af145898cd0d321591f546007e6f9545b9d2f570
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/experimental/eos_idealgas_vapor.f90
Log Message:
-----------
eos_idealgas_vapor/initialize_eos: don't zero out aux array during RELOAD
Is this the recommended way?
Commit: db2af5b261269f1e798abb1ae9073708f484f54a
https://github.com/pencil-code/pencil-code/commit/db2af5b261269f1e798abb1ae9073708f484f54a
Author: Kishore Gopalakrishnan <kish...@gmail.com>
Date: 2024-12-11 (Wed, 11 Dec 2024)
Changed paths:
M src/entropy.f90
Log Message:
-----------
entropy.f90/denergy_dt: fix mistake in comment
Compare: https://github.com/pencil-code/pencil-code/compare/5d98b77ee31c...db2af5b26126
To unsubscribe from these emails, change your notification settings at https://github.com/pencil-code/pencil-code/settings/notifications
Reply all
Reply to author
Forward
0 new messages