stripping trailing slashes

[alex...@solovyov.net]

Hello,

I have an API which I intend to rewrite in Pedestal, and it has one peculiar detail - all its routes end with a slash. While this may be not the best API in the world, I have to keep backward compatibility. And Pedestal generates regular expressions to match routes without trailing slashes.

I have two questions:

1) If it's possible to instruct Pedestal to respect my trailing slashes;
2) or, optionally, how do I strip trailing slashes from incoming requests, so that Pedestal will match them correctly. Can't figure out if I can do that with interceptors - it seems to return 404 before calling my interceptor.

[Paul deGrandis]

In your route definition, do your routes have trailing slashes?

If you just want to remove the trailing slash, you can do that in an interceptor.
You might try adding it to your own interceptor stack in your service map, to ensure it always runs before Pedestal begins routing your request.

Someone on the list can certainly help you down that path if you have questions!

Cheers,
Paul

[Alexander Solovyov]

Paul, yes, my routes have trailing slashes - but Pedestal ignores them and treats them like urls without trailing slashes. So we can say that's a bug. :) I guess I'll go "interceptor in the service map" way right now.

Linus, thanks for the link, I'll try that!

[Alexander Solovyov]

That worked and I'm happy for now. :)

(ic/defbefore strip-trailing

  [ctx]

  (update-in ctx [:request :path-info] string/replace #"/$" ""))

Not sure if the fact that urls with trailing slashes are treated like ones without them is a bug, I guess it is - but maybe that's a design decision?

[martin...@googlemail.com]

This is a very old thread but it shows up relatively high on Google and I think redirecting should be the preferred approach this. This way there will be no duplicate content issues and clients will be informed via 301 Moved Permanently that the URL they requested isn't meant to be used anymore.

So here we go, an interceptor that does just that:

(def redirect-trailing-slash-interceptor
{:name ::redirect-trailing-slash
:leave (fn [ctx]
(let [uri (-> ctx :request :uri)]
(cond-> ctx
(.endsWith uri "/")
(assoc :response {:status 301
:headers {"Location" (subs uri 0 (dec (.length uri)))}}))))})