HEADS UP renaming CLI commands

1 view
Skip to first unread message

Fabio R.

unread,
Dec 28, 2009, 1:29:18 PM12/28/09
to pear...@googlegroups.com
Hi guys,

Based on our recent discussions at http://github.com/fgrehm/pearfarm/issues/closed/#issue/4 I'm renaming some of our commands and dropping others.

This email is just to notify you guys so that if you are working on it you don't forget to double check your code when merging ;-)

I'll write again when I'm done.
--
Fábio Rehm

Fabio R.

unread,
Dec 28, 2009, 3:54:40 PM12/28/09
to pear...@googlegroups.com
Hi all,

Just finished renaming and pushed the code to a branch:
   http://github.com/fgrehm/pearfarm/tree/renaming

The first one to review and test the code merges it back into master and let us know :-)
(what about making this our "default" workflow for commits?)


Cheers,
--
Fábio Rehm

Alan Pinstein

unread,
Dec 28, 2009, 9:10:01 PM12/28/09
to pear...@googlegroups.com
Hey-

I just merged it with master, but left it on renaming and pushed my changes.

Can you take a look and see if it looks sane?

I am not sure if it was you, but it looks like someone ran it thru a code formatter. It makes it really hard to merge when that type of thing is done.

We can't all be using different code formatters, so for now let's just not re-format each other's code. In a week or so we can decide what formatter to use and add it to the workflow.

LMK how it looks.

Alan

Fabio R.

unread,
Dec 29, 2009, 12:07:16 AM12/29/09
to pear...@googlegroups.com
Hi all, the code just got merged.


Cheers,
--
Fábio Rehm
Reply all
Reply to author
Forward
0 new messages