pdrtpy 2.3.1 released!

[Marc W. Pound]

Greetings PDR aficionados!

We are happy to announce the newest release of the PDR Toolbox, pdrtpy.
 You can install the newest version 2.3.1 with 

pip install pdrtpy -U

(python version >=3.8 required).  The notebooks have also been updated.   The major changes are new kosma-tau 2020 models that match the physical parameters of the wk2020 models, and updated HII region diagnostic plots and FITS files.

Let us know if you have questions or issues.

thanks,
Marc & Mark

[Mai Như Tín]

Hi Marc & Mark,

Thank you for your updating.

It's seem to be the problem with the legend of LineRatioPlot when adding new model ratio have not fixed yet, right ?

Thanks,

Tin

[Marc W. Pound]

Hi Tin,

Oh, sorry, that has not been fixed.   It was reported in an email thread and not as a github issue, so I missed it when preparing this release.   I've just submitted it as github issue #80 so it remains visible.   

thanks,

Marc

[Marc W. Pound]

Tin,

If the model is added with the title keyword, e.g.

ms.add_model("CII_158/CO_43", ciico43, title="[C II] 158 $\mu$m / CO(J=4-3)")

does the bug still persist?

Marc

[Mai Như Tín]

Hi Marc,

Right, there's no problem with the modelplot, but for LineRatioPlot the bug still there.

Tin

[Aaron Bryant]

Hi Marc,

a late reply, but indeed titles for user added ratios don't propagate to plots like overlay_all_ratios and ratios_on_models.

this can be seen if I do e.g.:

for k in lrf._modelratios.values(): print(k.title)

the result is:

[O I] 63 $\mu$m / [C II] 158 $\mu$m
None
None
[O I] 145 $\mu$m / [O I] 63 $\mu$m
None
None
[C II] 158 $\mu$m / [O I] 145 $\mu$m
None
None
[C II] 158 $\mu$m / I$_{FIR}$
([O I] 63 $\mu$m + [C II] 158 $\mu$m) / I$_{FIR}$
([O I] 145 $\mu$m + [C II] 158 $\mu$m) / I$_{FIR}$

Nones are user added ratios with high-J CO lines.

However, the title DOES end up in e.g.

lrp.modelratio("OI_63/CO_1615")

n.b. I am a complete python novice, but I noticed that modelratio uses self._tool._modelset.table.loc[id]["title"] to grab the title, whereas overlay_all_ratios & ratios_on_models use self._tool._modelratios[k].title

thanks,

Aaron

[Marc W. Pound]

Sorry it took so long to circle back to this.   As it turns out the fix is easy:

In pdrtpy/modelset.py add this at line 214, after the assignment of m in _really_add_model(): 

m._title = title

I will make sure this is patched in the next release. 

Marc

--
You received this message because you are subscribed to the Google Groups "PDR Toolbox" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pdrt+uns...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/pdrt/4b5fbf19-75a0-41d2-b8d9-3c699f4dc7ffn%40googlegroups.com.

--

Dr. Marc Pound
Research Scientist
Astronomy Department
University of Maryland, College Park

https://www.astro.umd.edu/~mpound

mpo...@umd.edu | 301.405.1520 | https://umd.zoom.us/my/marc.pound