PDFium changes can now be reviewed on Gerrit!

[Aaron Gable]

Hey PDFium devs,

As you've probably heard, Chromium and related projects are in the process of changing over from using Rietveld for code review, to using Gerrit.

As part of that process, we'd like to invite you all to dogfood using Gerrit for your code reviews.

The following instructions apply to these repositories:

https://pdfium.googlesource.com/pdfium

https://pdfium.googlesource.com/pdfium_tests

To upload a change to Gerrit instead of Rietveld, just run

  `git cl upload --gerrit`

when uploading the change for the first time. Additional patchsets after the first will automatically upload to the same review. If you would like all of your reviews to go to Gerrit without having to pass the flag, simply run

  `git config --local gerrit.host true`

in your local repository checkout.

While using Gerrit, please make sure that you are using the newer Polymer-base PolyGerrit UI. You can switch between UIs using the link in the footer of every page.

This doc and this faq should hopefully answer the majority of your questions. If not, please reach out to us by emailing chrome-infr...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

In a few weeks, assuming things are working smoothly, we will switch the default so that all reviews will go to Gerrit, and you'll no longer need to pass the --gerrit flag. We'll communicate the timeline for that flag change clearly, and you can track the work towards it here:

https://bugs.chromium.org/p/chromium/issues/detail?id=665583

Thanks,

Aaron

[Aaron Gable]

A big thank you to everyone who tested PolyGerrit, uploaded or reviewed CLs there, and filed bugs against us to improve it. Thanks to your feedback, we're now ready to change the default code review system for pdfium.

On Tuesday, Jan 24, I will submit CLs changing the default code review system for pdfium and pdfium_tests.

Any currently in-flight CLs you have on Rietveld will be unaffected; you can finish reviewing and landing them as normal. Once you sync your checkout past the above commits, any new CLs you upload will go to Gerrit instead. If for some reason you really need to upload a change to Rietveld anyway, you can do so with `git cl upload --rietveld`.

Again, this doc and this faq should answer the majority of your questions. If not, please reach out to us by emailing chrome-infr...@google.com. If you have issues with uploading, reviewing, or landing CLs, or if you have issues with any automated tooling that interacts with your code reviews, please file a bug here. If you experience issues with Gerrit or PolyGerrit itself, please file a bug here.

Thanks,

Aaron

[Aaron Gable]

All relevant changes have been made! Once you've synced your local checkout to tip of tree, your next upload will go to Gerrit.

Thanks, everybody!

Aaron