Update pixel test for rendering that depends on /ToUnicode [pdfium : main]

[Lei Zhang (Gerrit)]

Attention needed from Andy Phan

Lei Zhang voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Andy Phan

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: I16afbb387052ac43825e0ef729fbfa3254461cb6

Gerrit-Change-Number: 143430

Gerrit-PatchSet: 4

Gerrit-Owner: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Andy Phan <andy...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: Pdfium LUCI CQ <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: pdfium-...@googlegroups.com

Gerrit-Attention: Andy Phan <andy...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Feb 2026 17:18:25 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Andy Phan (Gerrit)]

Attention needed from Lei Zhang

Andy Phan added 2 comments

Commit Message

Line 9, Patchset 4 (Latest):CL [1] unintentionally made the existing bug_42270459.in pixel test pass

Andy Phan . unresolved

If it passed, why does the text expectation need to be updated?

Line 11, Patchset 4 (Latest):Unsupress this test and update its test expectations to match the

Andy Phan . unresolved

Unsuppress

Open in Gerrit

Related details

Attention is currently required from:

• Lei Zhang

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: I16afbb387052ac43825e0ef729fbfa3254461cb6

Gerrit-Change-Number: 143430

Gerrit-PatchSet: 4

Gerrit-Owner: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Andy Phan <andy...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: Pdfium LUCI CQ <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: pdfium-...@googlegroups.com

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Feb 2026 21:50:34 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Lei Zhang (Gerrit)]

Attention needed from Andy Phan

Lei Zhang added 2 comments

Commit Message

Line 9, Patchset 4:CL [1] unintentionally made the existing bug_42270459.in pixel test pass

Andy Phan . resolved

If it passed, why does the text expectation need to be updated?

Lei Zhang

The checked -in expectation is wrong.

Line 11, Patchset 4:Unsupress this test and update its test expectations to match the

Andy Phan . resolved

Unsuppress

Lei Zhang

Done

Open in Gerrit

Related details

Attention is currently required from:

• Andy Phan

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: I16afbb387052ac43825e0ef729fbfa3254461cb6

Gerrit-Change-Number: 143430

Gerrit-PatchSet: 5

Gerrit-Owner: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Andy Phan <andy...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: Pdfium LUCI CQ <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: pdfium-...@googlegroups.com

Gerrit-Attention: Andy Phan <andy...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Feb 2026 21:59:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Andy Phan <andy...@chromium.org>

[Andy Phan (Gerrit)]

Attention needed from Lei Zhang

Andy Phan voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Lei Zhang

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: I16afbb387052ac43825e0ef729fbfa3254461cb6

Gerrit-Change-Number: 143430

Gerrit-PatchSet: 5

Gerrit-Owner: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Andy Phan <andy...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: Pdfium LUCI CQ <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: pdfium-...@googlegroups.com

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Feb 2026 22:06:34 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Lei Zhang (Gerrit)]

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: I16afbb387052ac43825e0ef729fbfa3254461cb6

Gerrit-Change-Number: 143430

Gerrit-PatchSet: 5

Gerrit-Owner: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Andy Phan <andy...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: Pdfium LUCI CQ <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: pdfium-...@googlegroups.com

Gerrit-Comment-Date: Fri, 20 Feb 2026 22:10:50 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Pdfium LUCI CQ (Gerrit)]

Pdfium LUCI CQ submitted the change

Change information

Commit message:

Update pixel test for rendering that depends on /ToUnicode

CL [1] unintentionally made the existing bug_42270459.in pixel test pass

by rejecting its /ToUnicode entry, which has an incorrect bfrange count.
Unsuppress this test and update its test expectations to match the
current rendering. The checked-in expectation was not quite right.

Add bug_42270459_2.in, which is bug_42270459.in but with the correct
bfrange count, to show the bug still happens. Suppress this new test
since it fails.

[1] https://pdfium-review.googlesource.com/126013

Bug: 42270459

Change-Id: I16afbb387052ac43825e0ef729fbfa3254461cb6

Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/143430

Reviewed-by: Andy Phan <andy...@chromium.org>

Commit-Queue: Lei Zhang <the...@chromium.org>

Files:

• M testing/SUPPRESSIONS
• A testing/resources/pixel/bug_42270459_2.in
• A testing/resources/pixel/bug_42270459_2_expected.pdf.0.png
• M testing/resources/pixel/bug_42270459_expected.pdf.0.png
• A testing/resources/pixel/bug_42270459_expected_skia_linux.pdf.0.png
• A testing/resources/pixel/bug_42270459_expected_skia_win.pdf.0.png

Change size: M

Delta: 6 files changed, 102 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Andy Phan

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: I16afbb387052ac43825e0ef729fbfa3254461cb6

Gerrit-Change-Number: 143430

Gerrit-PatchSet: 6

Gerrit-Owner: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Andy Phan <andy...@chromium.org>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-Reviewer: Pdfium LUCI CQ <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: pdfium-...@googlegroups.com