Replace FX_NUMSTYLE defines with NumStyle enum + Mask [pdfium : main]

0 views
Skip to first unread message

Lei Zhang (Gerrit)

unread,
Jun 23, 2026, 10:09:17 PM (2 days ago) Jun 23
to Helmut Januschka, Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Helmut Januschka and Tom Sepez

Lei Zhang voted and added 2 comments

Votes added by Lei Zhang

Code-Review+1

2 comments

Commit Message
Line 9, Patchset 1 (Latest):Convert the internal numeric format style bitmask from preprocessor macros to a scoped enum used with fxcrt::Mask. Tighten dwStyle, dwFormatStyle, and dwNumStyle types so type-safe operations replace raw uint32_t bitwise math.
Lei Zhang . unresolved

wrap

File xfa/fgas/crt/cfgas_stringformatter.cpp
Line 1080, Patchset 1 (Latest): *dwStyle = {};
Lei Zhang . unresolved

Call Clear()?

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I1ec4b63b4f2756d6db1a3ca52be9c83278ec0a5c
Gerrit-Change-Number: 148830
Gerrit-PatchSet: 1
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Jun 2026 02:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Jun 24, 2026, 3:19:04 AM (23 hours ago) Jun 24
to Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang and Tom Sepez

Helmut Januschka added 2 comments

Commit Message
Line 9, Patchset 1:Convert the internal numeric format style bitmask from preprocessor macros to a scoped enum used with fxcrt::Mask. Tighten dwStyle, dwFormatStyle, and dwNumStyle types so type-safe operations replace raw uint32_t bitwise math.
Lei Zhang . resolved

wrap

Helmut Januschka

Done

File xfa/fgas/crt/cfgas_stringformatter.cpp
Line 1080, Patchset 1: *dwStyle = {};
Lei Zhang . resolved

Call Clear()?

Helmut Januschka

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
  • Tom Sepez
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I1ec4b63b4f2756d6db1a3ca52be9c83278ec0a5c
Gerrit-Change-Number: 148830
Gerrit-PatchSet: 3
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Jun 2026 07:18:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 24, 2026, 1:09:50 PM (13 hours ago) Jun 24
to Helmut Januschka, Lei Zhang, Tom Sepez, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Helmut Januschka and Tom Sepez

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I1ec4b63b4f2756d6db1a3ca52be9c83278ec0a5c
Gerrit-Change-Number: 148830
Gerrit-PatchSet: 3
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Jun 2026 17:09:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Jun 24, 2026, 2:57:11 PM (12 hours ago) Jun 24
to Helmut Januschka, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Helmut Januschka

Tom Sepez voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: I1ec4b63b4f2756d6db1a3ca52be9c83278ec0a5c
    Gerrit-Change-Number: 148830
    Gerrit-PatchSet: 3
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
    Gerrit-Comment-Date: Wed, 24 Jun 2026 18:57:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    Jun 24, 2026, 4:32:21 PM (10 hours ago) Jun 24
    to Helmut Januschka, Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com

    pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Change information

    Commit message:
    Replace FX_NUMSTYLE defines with NumStyle enum + Mask


    Convert the internal numeric format style bitmask from preprocessor
    macros to a scoped enum used with fxcrt::Mask. Tighten dwStyle,
    dwFormatStyle, and dwNumStyle types so type-safe operations replace raw
    uint32_t bitwise math.
    Bug: 42270078
    Change-Id: I1ec4b63b4f2756d6db1a3ca52be9c83278ec0a5c
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Reviewed-by: Tom Sepez <tse...@chromium.org>
    Commit-Queue: Tom Sepez <tse...@chromium.org>
    Files:
    • M core/fxcrt/mask.h
    • M core/fxcrt/mask_unittest.cpp
    • M xfa/fgas/crt/cfgas_stringformatter.cpp
    • M xfa/fgas/crt/cfgas_stringformatter.h
    Change size: S
    Delta: 4 files changed, 29 insertions(+), 18 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Tom Sepez, +1 by Lei Zhang
     Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: pdfium 
    

     Gerrit-Branch: main 
    

     Gerrit-Change-Id: I1ec4b63b4f2756d6db1a3ca52be9c83278ec0a5c 
    

     Gerrit-Change-Number: 148830 
    

     Gerrit-PatchSet: 4 
    

     Gerrit-Owner: Helmut Januschka <hel...@januschka.com> 
    

     Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com> 
    

     Gerrit-Reviewer: Lei Zhang <the...@chromium.org> 
    

     Gerrit-Reviewer: Tom Sepez <tse...@chromium.org> 
    

    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages