Pass CFX_FontMapper to CFX_FolderFontInfo methods. [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Jun 23, 2026, 4:42:07 PM (2 days ago) Jun 23
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 23, 2026, 4:46:58 PM (2 days ago) Jun 23
to Tom Sepez, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
File core/fxge/cfx_folderfontinfo.h
Line 16, Patchset 2 (Latest):
#include "core/fxcrt/unowned_ptr.h"Lei Zhang . unresolved
No longer used. (Having a case of deja vu)
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jun 23, 2026, 4:48:43 PM (2 days ago) Jun 23
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Tom Sepez voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Sepez
| Commit-Queue | +2 |
1 comment
File core/fxge/cfx_folderfontinfo.h
No longer used. (Having a case of deja vu)
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jun 23, 2026, 4:57:22 PM (2 days ago) Jun 23
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Sepez
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 23, 2026, 4:58:28 PM (2 days ago) Jun 23
to Tom Sepez, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jun 23, 2026, 4:58:51 PM (2 days ago) Jun 23
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Tom Sepez voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 23, 2026, 5:53:39 PM (2 days ago) Jun 23
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Pass CFX_FontMapper to CFX_FolderFontInfo methods.
Avoids the possibility of a stale reference, esp. during tests. The
callers all already take this as an argument, so no need to store.
-- Make blank line change from previous CL.
Change-Id: Ia4b8aa72164313442d04ee8463103f4ad5a7e896
Reviewed-by: Lei Zhang <the...@chromium.org>
Auto-Submit: Tom Sepez <tse...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Files:
- M core/fxge/cfx_folderfontinfo.cpp
- M core/fxge/cfx_folderfontinfo.h
- M core/fxge/win32/cwin32_platform.cpp
Change size: M
Delta: 3 files changed, 33 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages