Privatize OpenSavedDocument() family of methods [pdfium : main]
2 views
Skip to first unread message
Aryan Krishnan (Gerrit)
Feb 19, 2026, 6:29:13 AM (3 days ago) Feb 19
to Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Aryan Krishnan
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Aryan Krishnan . resolved
Hey guys, made the old non-scoped things private. Updated some of the comments as well to be able to redirect people to the scoped methods more clearly.
Do let me know if we should leave the old API as public in case some tests in future may want to exercise them, or if we should make it private as is. Also was considering removing the "Scoped" from the name to make it cleaner, but let us consider that in a separate CL if so.
Thanks!
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Feb 19, 2026, 8:45:25 AM (3 days ago) Feb 19
to Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Aryan Krishnan
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Feb 19, 2026, 2:48:36 PM (3 days ago) Feb 19
to Aryan Krishnan, Pdfium LUCI CQ, Lei Zhang, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Aryan Krishnan and Lei Zhang
Tom Sepez voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andy Phan
- Aryan Krishnan
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Feb 19, 2026, 3:02:54 PM (3 days ago) Feb 19
to Aryan Krishnan, Tom Sepez, Pdfium LUCI CQ, Lei Zhang, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan and Aryan Krishnan
Lei Zhang added 1 comment![]( "Open in Gerrit")
File testing/embedder_test.h
Line 402, Patchset 5 (Latest):
// Manual memory management versions of OpenScopedSavedDocument*(). These areLei Zhang . unresolved
There's no way for external callers to access these private methods, so please rephrase this.
Related details
Attention is currently required from:
- Andy Phan
- Aryan Krishnan
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andy Phan (Gerrit)
Feb 19, 2026, 4:15:04 PM (3 days ago) Feb 19
to Aryan Krishnan, Tom Sepez, Pdfium LUCI CQ, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan
Andy Phan voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Aryan Krishnan
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Feb 19, 2026, 8:45:22 PM (3 days ago) Feb 19
to Andy Phan, Tom Sepez, Pdfium LUCI CQ, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
File testing/embedder_test.h
Line 402, Patchset 5:
// Manual memory management versions of OpenScopedSavedDocument*(). These areLei Zhang . resolved
There's no way for external callers to access these private methods, so please rephrase this.
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Feb 19, 2026, 8:51:08 PM (3 days ago) Feb 19
to Aryan Krishnan, Lei Zhang, Andy Phan, Tom Sepez, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Aryan Krishnan and Tom Sepez
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andy Phan
- Aryan Krishnan
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andy Phan (Gerrit)
Feb 20, 2026, 2:16:09 PM (2 days ago) Feb 20
to Aryan Krishnan, Lei Zhang, Tom Sepez, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Tom Sepez
Andy Phan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Aryan Krishnan
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Feb 20, 2026, 2:18:21 PM (2 days ago) Feb 20
to Andy Phan, Lei Zhang, Tom Sepez, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Aryan Krishnan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Aryan Krishnan
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Feb 20, 2026, 3:12:43 PM (2 days ago) Feb 20
to Aryan Krishnan, Andy Phan, Lei Zhang, Tom Sepez, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Privatize OpenSavedDocument() family of methods
Move the manual memory management versions of OpenSavedDocument(),
OpenSavedDocumentWithPassword(), and CloseSavedDocument() to the
private section of EmbedderTest.
These methods are deprecated for general use. Relocating them
encourages the use of ScopedSavedDoc variants, which leverage RAII
to ensure automatic resource cleanup and prevent potential memory
leaks in tests. Updated documentation clarifies that these manual
variants should only be used when Scoped* alternatives are not
applicable.
Bug: 483848089
Change-Id: Icaedef36d89d26ead8b1db340d02a8ff1a2f5be7
Reviewed-by: Lei Zhang <the...@chromium.org>
Reviewed-by: Andy Phan <andy...@chromium.org>
Commit-Queue: Aryan Krishnan <aryankr...@gmail.com>
Files:
- M fpdfsdk/fpdf_edit_embeddertest.cpp
- M fpdfsdk/fpdf_editpath_embeddertest.cpp
- M fpdfsdk/fpdf_ppo_embeddertest.cpp
- M fpdfsdk/fpdf_save_embeddertest.cpp
- M testing/embedder_test.h
Change size: S
Delta: 5 files changed, 21 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang, +1 by Andy Phan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages