Groups
Groups
Sign in
Groups
Groups
pdfium-reviews
Conversations
About
Send feedback
Help
Merge to XFA: CPDF_Object() constructor should set its internal m_Type variable. (issue 916953002 by tsepez@chromium.org)
0 views
Skip to first unread message
tse...@chromium.org
unread,
Feb 11, 2015, 3:56:41 PM
2/11/15
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to the...@chromium.org, pdfium-...@googlegroups.com
Reviewers: Lei Zhang,
Description:
Merge to XFA: CPDF_Object() constructor should set its internal m_Type
variable.
Original Review URL:
https://codereview.chromium.org/880233005
TBR=
the...@chromium.org
Please review this at
https://codereview.chromium.org/916953002/
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Affected files (+31, -87 lines):
M core/include/fpdfapi/fpdf_objects.h
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp
tse...@chromium.org
unread,
Feb 11, 2015, 3:56:57 PM
2/11/15
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to the...@chromium.org, pdfium-...@googlegroups.com
Committed patchset #1 (id:1) manually as
0e8141a8d3d2c1ed51561815ac26e5bba801a629 (presubmit successful).
https://codereview.chromium.org/916953002/
the...@chromium.org
unread,
Feb 11, 2015, 4:23:25 PM
2/11/15
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to tse...@chromium.org, pdfium-...@googlegroups.com
lgtm
https://codereview.chromium.org/916953002/
Reply all
Reply to author
Forward
0 new messages