Rename AdobeCMYK_to_sRGB() and AdobeCMYK_to_sRGB1() [pdfium : main]

0 views
Skip to first unread message

Andy Phan (Gerrit)

unread,
May 4, 2026, 4:23:10 PM (9 days ago) May 4
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Andy Phan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I2fcf60769a0aac033f66ddca86a3d1db7c8e032b
Gerrit-Change-Number: 146930
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 04 May 2026 20:23:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
May 4, 2026, 4:25:49 PM (9 days ago) May 4
to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I2fcf60769a0aac033f66ddca86a3d1db7c8e032b
Gerrit-Change-Number: 146930
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Mon, 04 May 2026 20:25:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
May 4, 2026, 6:33:18 PM (9 days ago) May 4
to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Rename AdobeCMYK_to_sRGB() and AdobeCMYK_to_sRGB1()

AdobeCMYK_to_sRGB() -> AdobeCmykToStandardRgbF()
AdobeCMYK_to_sRGB1() -> AdobeCmykToStandardRgb()
Change-Id: I2fcf60769a0aac033f66ddca86a3d1db7c8e032b
Reviewed-by: Andy Phan <andy...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
  • M core/fpdfapi/page/cpdf_devicecs.cpp
  • M core/fxcodec/progressive_decoder.cpp
  • M core/fxge/dib/cfx_cmyk_to_srgb.cpp
  • M core/fxge/dib/cfx_cmyk_to_srgb.h
  • M core/fxge/dib/cfx_cmyk_to_srgb_unittest.cpp
Change size: S
Delta: 5 files changed, 26 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Andy Phan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I2fcf60769a0aac033f66ddca86a3d1db7c8e032b
Gerrit-Change-Number: 146930
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages