Rename CPDF_TextObject::CountChars() to CharCount() [pdfium : main]
0 views
Skip to first unread message
Andy Phan (Gerrit)
4:26 PM (6 hours ago) 4:26 PM
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Andy Phan voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
4:31 PM (6 hours ago) 4:31 PM
to Lei Zhang, Andy Phan, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Lei Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
4:32 PM (6 hours ago) 4:32 PM
to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Rename CPDF_TextObject::CountChars() to CharCount()
Previously, CountChars() had to actually count the characters and skip
the invalid ones. Now it just returns char_codes_.size(), so rename it
to more accurately reflect what it does. Also get rid of some internal
usage in CPDF_TextObject and use range-based for-loops instead.
Change-Id: Id115d7917212f242076c8faf6824cf30468ba2c2
Reviewed-by: Andy Phan <andy...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
- M core/fpdfapi/page/cpdf_textobject.cpp
- M core/fpdfapi/page/cpdf_textobject.h
- M core/fpdftext/cpdf_textpage.cpp
Change size: S
Delta: 3 files changed, 8 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andy Phan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages