Roll build, buildtools, libc++, and llvm-libc [pdfium : main]

0 views
Skip to first unread message

April Kallmeyer (Gerrit)

unread,
Jun 1, 2026, 6:09:16 PM (3 days ago) Jun 1
to Lei Zhang, Andy Phan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Andy Phan and Lei Zhang

April Kallmeyer voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Lei Zhang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I63389c20c6bed7137caba466b8301d122f44b5cd
Gerrit-Change-Number: 148950
Gerrit-PatchSet: 4
Gerrit-Owner: April Kallmeyer <a...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: April Kallmeyer <a...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jun 2026 22:09:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 1, 2026, 6:28:26 PM (3 days ago) Jun 1
to April Kallmeyer, Lei Zhang, Andy Phan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Andy Phan and April Kallmeyer

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • April Kallmeyer
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I63389c20c6bed7137caba466b8301d122f44b5cd
Gerrit-Change-Number: 148950
Gerrit-PatchSet: 4
Gerrit-Owner: April Kallmeyer <a...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: April Kallmeyer <a...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: April Kallmeyer <a...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jun 2026 22:28:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

April Kallmeyer (Gerrit)

unread,
Jun 1, 2026, 6:42:39 PM (3 days ago) Jun 1
to Lei Zhang, Andy Phan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Andy Phan

April Kallmeyer voted Auto-Submit+0

Auto-Submit+0
Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I63389c20c6bed7137caba466b8301d122f44b5cd
Gerrit-Change-Number: 148950
Gerrit-PatchSet: 4
Gerrit-Owner: April Kallmeyer <a...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: April Kallmeyer <a...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jun 2026 22:42:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Andy Phan (Gerrit)

unread,
Jun 1, 2026, 7:06:35 PM (3 days ago) Jun 1
to April Kallmeyer, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from April Kallmeyer

Andy Phan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • April Kallmeyer
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: I63389c20c6bed7137caba466b8301d122f44b5cd
    Gerrit-Change-Number: 148950
    Gerrit-PatchSet: 4
    Gerrit-Owner: April Kallmeyer <a...@chromium.org>
    Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: April Kallmeyer <a...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Attention: April Kallmeyer <a...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Jun 2026 23:06:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Jun 1, 2026, 7:16:51 PM (3 days ago) Jun 1
    to April Kallmeyer, Lei Zhang, Andy Phan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
    Attention needed from April Kallmeyer

    Lei Zhang voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • April Kallmeyer
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: I63389c20c6bed7137caba466b8301d122f44b5cd
    Gerrit-Change-Number: 148950
    Gerrit-PatchSet: 4
    Gerrit-Owner: April Kallmeyer <a...@chromium.org>
    Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: April Kallmeyer <a...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Attention: April Kallmeyer <a...@chromium.org>
    Gerrit-Comment-Date: Mon, 01 Jun 2026 23:16:48 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    Jun 1, 2026, 7:17:44 PM (3 days ago) Jun 1
    to April Kallmeyer, Lei Zhang, Andy Phan, pdfium-...@googlegroups.com

    pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Change information

    Commit message:
    Roll build, buildtools, libc++, and llvm-libc

    The //.gn change is necessary for use_cxx23 builds. The same line was
    added to the Chromium //.gn in
    https://crrev.com/2e50711003a48a8966c0126b5c3cb646b3116979

    Roll build/ 8a46ede8e..613f5c13b (187 commits)
    Roll buildtools/ 5e7f45b2c..e06be5db4 (18 commits)
    Roll third_party/libc++/src/ be1c391ac..5abc7f839 (17 commits)
    Roll third_party/llvm-libc/src/ ada036045..9309c117e (181 commits)

    https://chromium.googlesource.com/chromium/src/build.git/+log/8a46ede8ea86..613f5c13bccb
    https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5e7f45b2c8d0..e06be5db47ae
    https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/be1c391acca0..5abc7f839700
    https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/ada0360457d5..9309c117ebae

    Created with:
    roll-dep build
    roll-dep buildtools
    roll-dep third_party/libc++/src
    roll-dep third_party/llvm-libc/src
    Change-Id: I63389c20c6bed7137caba466b8301d122f44b5cd
    Commit-Queue: Lei Zhang <the...@chromium.org>
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Reviewed-by: Andy Phan <andy...@chromium.org>
    Files:
    • M .gn
    • M DEPS
    Change size: S
    Delta: 2 files changed, 8 insertions(+), 4 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Andy Phan, +1 by Lei Zhang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: I63389c20c6bed7137caba466b8301d122f44b5cd
    Gerrit-Change-Number: 148950
    Gerrit-PatchSet: 5
    Gerrit-Owner: April Kallmeyer <a...@chromium.org>
    Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: April Kallmeyer <a...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages