Replace c-style casts in cfgas_decimal.cpp with static_casts [pdfium : main]

0 views
Skip to first unread message

Aryan Krishnan (Gerrit)

unread,
Jun 1, 2026, 11:36:58 PM (3 days ago) Jun 1
to pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez

Aryan Krishnan added 4 comments

Commit Message
Line 7, Patchset 3:Replace c-style casts in cfags_decimal.cpp with static_casts
Lei Zhang . resolved

typo

Aryan Krishnan

Done

Line 10, Patchset 3:cfags_decimal.cpp with static_casts.
Lei Zhang . resolved

(x2)

Aryan Krishnan

Done

File xfa/fgas/crt/cfgas_decimal.cpp
Line 351, Patchset 3: hi_ = hi_ * 0xA + FXMATH_DECIMAL_RSHIFT32BIT((uint64_t)mid_ * 0xA);
Lei Zhang . resolved

More here.

Aryan Krishnan

Done

Line 373, Patchset 3: uint8_t outputlen = (uint8_t)tmpbuf.GetLength();
Lei Zhang . resolved

And here, if you want to catch them all.

Aryan Krishnan

Gotta catch 'em all :)

Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Lei Zhang
  • Tom Sepez
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ifd3a96313e51048c2f8afcf7d8d45c6f312ac378
Gerrit-Change-Number: 148851
Gerrit-PatchSet: 5
Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jun 2026 03:36:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
unsatisfied_requirement
open
diffy

Aryan Krishnan (Gerrit)

unread,
Jun 1, 2026, 11:38:47 PM (3 days ago) Jun 1
to pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez

Aryan Krishnan voted Commit-Queue+1

Commit-Queue+1
Gerrit-Comment-Date: Tue, 02 Jun 2026 03:38:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 2, 2026, 1:24:06 PM (2 days ago) Jun 2
to Aryan Krishnan, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Aryan Krishnan and Tom Sepez

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Aryan Krishnan
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ifd3a96313e51048c2f8afcf7d8d45c6f312ac378
Gerrit-Change-Number: 148851
Gerrit-PatchSet: 5
Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jun 2026 17:24:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Andy Phan (Gerrit)

unread,
Jun 2, 2026, 1:52:41 PM (2 days ago) Jun 2
to Aryan Krishnan, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Tom Sepez

Andy Phan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aryan Krishnan
  • Tom Sepez
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifd3a96313e51048c2f8afcf7d8d45c6f312ac378
    Gerrit-Change-Number: 148851
    Gerrit-PatchSet: 5
    Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Comment-Date: Tue, 02 Jun 2026 17:52:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Aryan Krishnan (Gerrit)

    unread,
    Jun 2, 2026, 2:06:00 PM (2 days ago) Jun 2
    to Andy Phan, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, Tom Sepez, pdfium-...@googlegroups.com
    Attention needed from Tom Sepez

    Aryan Krishnan voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tom Sepez
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifd3a96313e51048c2f8afcf7d8d45c6f312ac378
    Gerrit-Change-Number: 148851
    Gerrit-PatchSet: 5
    Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Jun 2026 18:05:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    Jun 2, 2026, 2:07:37 PM (2 days ago) Jun 2
    to Aryan Krishnan, Andy Phan, Lei Zhang, Tom Sepez, pdfium-...@googlegroups.com

    pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Change information

    Commit message:
    Replace c-style casts in cfgas_decimal.cpp with static_casts

    This CL helps modernise the codebase by replacing the c-style casts in
    cfgas_decimal.cpp with static_casts.
    Change-Id: Ifd3a96313e51048c2f8afcf7d8d45c6f312ac378
    Reviewed-by: Lei Zhang <the...@chromium.org>
    Reviewed-by: Andy Phan <andy...@chromium.org>
    Commit-Queue: Aryan Krishnan <aryankr...@gmail.com>
    Files:
    • M xfa/fgas/crt/cfgas_decimal.cpp
    Change size: S
    Delta: 1 file changed, 18 insertions(+), 16 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Lei Zhang, +1 by Andy Phan
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifd3a96313e51048c2f8afcf7d8d45c6f312ac378
    Gerrit-Change-Number: 148851
    Gerrit-PatchSet: 6
    Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages