Return fixed-size spans from CPDF_TransferFunc. [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Apr 7, 2026, 12:42:00 PM (4 days ago) Apr 7
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Apr 7, 2026, 1:22:41 PM (4 days ago) Apr 7
to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Apr 7, 2026, 1:22:56 PM (4 days ago) Apr 7
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Apr 7, 2026, 1:23:54 PM (4 days ago) Apr 7
to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Lei Zhang added 1 comment![]( "Open in Gerrit")
File core/fpdfapi/page/cpdf_transferfuncdib.h
Line 37, Patchset 3 (Latest):
const pdfium::span<const uint8_t, kSampleCount> r_samples_;Lei Zhang . resolved
Since these really point into the members of `transfer_func_`, which are `const FixedSizeDataVector<uint8_t>`, I'm not expecting any UAFs here.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Apr 7, 2026, 1:24:48 PM (4 days ago) Apr 7
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Return fixed-size spans from CPDF_TransferFunc.
Then use fixed-sized spans in CPDF_TransferFuncDIB. The downside
is that we need to give up raw_span since it isn't a fixed size
span.
Change-Id: Ia3afec6bbe5b799a3d279dc60b66c62889f5b94f
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Files:
- M core/fpdfapi/page/cpdf_transferfunc.cpp
- M core/fpdfapi/page/cpdf_transferfunc.h
- M core/fpdfapi/page/cpdf_transferfuncdib.cpp
- M core/fpdfapi/page/cpdf_transferfuncdib.h
Change size: S
Delta: 4 files changed, 21 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages