Clarify FPDF_NewXObjectFromPage() return value's lifetime [pdfium : main]

0 views
Skip to first unread message

Andy Phan (Gerrit)

unread,
May 7, 2026, 2:51:23 PM (6 days ago) May 7
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

Andy Phan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I474fcbb7d034bbe52b1aeedf2e89a3b7bd13c9a8
Gerrit-Change-Number: 147290
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 07 May 2026 18:51:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
May 7, 2026, 2:57:07 PM (6 days ago) May 7
to Lei Zhang, Andy Phan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com

Lei Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I474fcbb7d034bbe52b1aeedf2e89a3b7bd13c9a8
Gerrit-Change-Number: 147290
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 07 May 2026 18:57:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
May 7, 2026, 2:58:02 PM (6 days ago) May 7
to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com

pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Clarify FPDF_NewXObjectFromPage() return value's lifetime

Improve the documentation to make it clear the returned FPDF_XOBJECT's
lifetime is tied to the destination document and not the source
document. Augment FPDFPPOEmbedderTest.ImportPageToXObject to close the
source document immediately after the FPDF_NewXObjectFromPage() call to
show it works.
Change-Id: I474fcbb7d034bbe52b1aeedf2e89a3b7bd13c9a8
Reviewed-by: Andy Phan <andy...@chromium.org>
Commit-Queue: Lei Zhang <the...@chromium.org>
Files:
  • M fpdfsdk/fpdf_ppo_embeddertest.cpp
  • M public/fpdf_ppo.h
Change size: XS
Delta: 2 files changed, 6 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Andy Phan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I474fcbb7d034bbe52b1aeedf2e89a3b7bd13c9a8
Gerrit-Change-Number: 147290
Gerrit-PatchSet: 2
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages