Replace FXMATH_DECIMAL macros with constexpr in cfgas_decimal.cpp [pdfium : main]

0 views
Skip to first unread message

Aryan Krishnan (Gerrit)

unread,
May 31, 2026, 1:41:52 PM (4 days ago) May 31
to Helmut Januschka, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Helmut Januschka

Aryan Krishnan added 1 comment

Commit Message
Line 9, Patchset 1 (Latest):Convert the file-local FXMATH_DECIMAL_SCALELIMIT and the two 32-bit shift helper macros into proper constexpr declarations:
Aryan Krishnan . unresolved

Wrap line 9

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I205f8539a3bed737baa5dc7e8921936334287ed5
Gerrit-Change-Number: 148833
Gerrit-PatchSet: 1
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Comment-Date: Sun, 31 May 2026 17:41:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages