Replace PNG_ERROR_SIZE with constexpr [pdfium : main]

0 views
Skip to first unread message

Aryan Krishnan (Gerrit)

unread,
May 31, 2026, 10:06:23 AM (4 days ago) May 31
to Helmut Januschka, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Helmut Januschka

Aryan Krishnan added 2 comments

Commit Message
Line 7, Patchset 2 (Latest):Replace PNG_ERROR_SIZE with constexpr
Aryan Krishnan . unresolved

a constexpr

File core/fxcodec/png/libpng_png_decoder.cpp
Line 32, Patchset 2 (Latest):constexpr size_t kPngErrorSize = 256;
Aryan Krishnan . unresolved

This is not in an anonymous namespace (but the description says it should).

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ia5f06ebc96f95a5e9a8cf65e531507cf2c97a6f5
Gerrit-Change-Number: 148790
Gerrit-PatchSet: 2
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Comment-Date: Sun, 31 May 2026 14:06:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
May 31, 2026, 1:09:46 PM (4 days ago) May 31
to Lei Zhang, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Lei Zhang

Helmut Januschka added 3 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Helmut Januschka . resolved

thanks! :)

Commit Message
Line 7, Patchset 2:Replace PNG_ERROR_SIZE with constexpr
Aryan Krishnan . resolved

a constexpr

Helmut Januschka

Done

File core/fxcodec/png/libpng_png_decoder.cpp
Line 32, Patchset 2:constexpr size_t kPngErrorSize = 256;
Aryan Krishnan . resolved

This is not in an anonymous namespace (but the description says it should).

Helmut Januschka

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Aryan Krishnan
  • Lei Zhang
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia5f06ebc96f95a5e9a8cf65e531507cf2c97a6f5
    Gerrit-Change-Number: 148790
    Gerrit-PatchSet: 3
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Attention: Lei Zhang <the...@chromium.org>
    Gerrit-Attention: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Comment-Date: Sun, 31 May 2026 17:09:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Aryan Krishnan <aryankr...@gmail.com>
    unsatisfied_requirement
    open
    diffy

    Aryan Krishnan (Gerrit)

    unread,
    May 31, 2026, 10:35:08 PM (4 days ago) May 31
    to Helmut Januschka, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
    Attention needed from Helmut Januschka and Lei Zhang

    Aryan Krishnan added 1 comment

    Commit Message
    Line 7, Patchset 2:Replace PNG_ERROR_SIZE with constexpr
    Aryan Krishnan . unresolved

    a constexpr

    Helmut Januschka

    Done

    Aryan Krishnan

    Not quite yet, maybe you forgot to save? On my end it still says "With constexpr"

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Helmut Januschka
    • Lei Zhang
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: pdfium
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia5f06ebc96f95a5e9a8cf65e531507cf2c97a6f5
      Gerrit-Change-Number: 148790
      Gerrit-PatchSet: 3
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
      Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>
      Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
      Gerrit-Attention: Lei Zhang <the...@chromium.org>
      Gerrit-Comment-Date: Mon, 01 Jun 2026 02:35:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Helmut Januschka <hel...@januschka.com>
      Comment-In-Reply-To: Aryan Krishnan <aryankr...@gmail.com>
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages