Cleanup CPVT_WordInfo constructors [pdfium : main]
0 views
Skip to first unread message
Seung Hyun Jin (Gerrit)
Jun 23, 2026, 4:18:32 PM (2 days ago) Jun 23
to Lei Zhang, April Kallmeyer, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Seung Hyun Jin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Seung Hyun Jin . resolved
moved cleanup to this CL, 149790 only has addition of is_rtl
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 23, 2026, 4:24:42 PM (2 days ago) Jun 23
to Seung Hyun Jin, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, April Kallmeyer, pdfium-...@googlegroups.com
Attention needed from Seung Hyun Jin
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Seung Hyun Jin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Seung Hyun Jin (Gerrit)
Jun 23, 2026, 4:58:02 PM (2 days ago) Jun 23
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, April Kallmeyer, pdfium-...@googlegroups.com
Seung Hyun Jin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 23, 2026, 4:59:35 PM (2 days ago) Jun 23
to Seung Hyun Jin, Lei Zhang, April Kallmeyer, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Cleanup CPVT_WordInfo constructors
Remove the unused default constructor `CPVT_WordInfo()`. Update the
copy constructor, destructor, and assignment operator to use
`= default;`
Bug: 40115028
Change-Id: I598133f6b45e2a259c4720bce39ea5def4f51d27
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Seung Hyun Jin <seungh...@google.com>
Files:
- M core/fpdfdoc/cpvt_wordinfo.cpp
- M core/fpdfdoc/cpvt_wordinfo.h
Change size: S
Delta: 2 files changed, 2 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages