Add public APIs to access PDF dictionary objects [pdfium : main]
0 views
Skip to first unread message
Aryan Krishnan (Gerrit)
Apr 30, 2026, 4:29:49 AM (13 days ago) Apr 30
to Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Apr 30, 2026, 6:46:54 AM (13 days ago) Apr 30
to pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Aryan Krishnan . resolved
Hey guys, saw this (pretty old) issue about page dictionaries and found an existing CPDF_ api for this so I thought about making it public (while also adding a set of tests for public API and a few more things. Let me know if we:
a. Need any documentation/design docs of any kind
b. If there needs to be any discussion on whether to go ahead with the feature.
The page dictionary is likely just a start and after this I'd want to give a shot at some of the other dictionaries.
Thanks!
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Apr 30, 2026, 12:52:32 PM (13 days ago) Apr 30
to pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
File fpdfsdk/fpdf_dict.cpp
Line 36, Patchset 6 (Latest):
reinterpret_cast<FPDF_STRING>(string_ptr->GetString().c_str());Aryan Krishnan . unresolved
This could probably UAF, so need to find a way around it, might consider the buffer/buflen that a lot of other apis use.
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Apr 30, 2026, 2:33:49 PM (13 days ago) Apr 30
to pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
File fpdfsdk/fpdf_dict.cpp
Line 36, Patchset 6:
reinterpret_cast<FPDF_STRING>(string_ptr->GetString().c_str());Aryan Krishnan . resolved
This could probably UAF, so need to find a way around it, might consider the buffer/buflen that a lot of other apis use.
Aryan Krishnan
Done
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Apr 30, 2026, 2:40:53 PM (13 days ago) Apr 30
to pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan voted and added 2 comments![]( "Open in Gerrit")
Votes added by Aryan Krishnan
| Commit-Queue | +1 |
2 comments
File fpdfsdk/fpdf_dict.cpp
Line 70, Patchset 7:
return reinterpret_cast<FPDF_DICTIONARY>(dict->GetDictFor(key).Get());Aryan Krishnan . resolved
CPDFDictFromFPDFDict(). Done.
File fpdfsdk/fpdf_dict_embeddertest.cpp
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
Apr 30, 2026, 2:55:34 PM (13 days ago) Apr 30
to pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez
Aryan Krishnan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Aryan Krishnan
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
geisserml (Gerrit)
May 9, 2026, 4:17:37 PM (4 days ago) May 9
to Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Aryan Krishnan, Lei Zhang and Tom Sepez
geisserml added 1 comment![]( "Open in Gerrit")
File fpdfsdk/fpdf_dict.cpp
Line 80, Patchset 10 (Latest):
return {rect.left, rect.top, rect.right, rect.bottom};geisserml . unresolved
Maybe use an out parameter and reserve the return for a success/failure indicator? Same for GetMatrix() below.
(I don't have any experience in the matter, I was just under the impression that most other APIs seem to be designed that way...)
Related details
Attention is currently required from:
- Andy Phan
- Aryan Krishnan
- Lei Zhang
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
May 10, 2026, 1:28:45 AM (4 days ago) May 10
to geisserml, pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang, Tom Sepez and geisserml
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
File fpdfsdk/fpdf_dict.cpp
Line 80, Patchset 10 (Latest):
return {rect.left, rect.top, rect.right, rect.bottom};geisserml . unresolved
Maybe use an out parameter and reserve the return for a success/failure indicator? Same for GetMatrix() below.
(I don't have any experience in the matter, I was just under the impression that most other APIs seem to be designed that way...)
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
- geisserml
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
May 11, 2026, 5:00:54 AM (2 days ago) May 11
to geisserml, pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang, Tom Sepez and geisserml
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
File fpdfsdk/fpdf_dict.cpp
Aryan KrishnanMaybe use an out parameter and reserve the return for a success/failure indicator? Same for GetMatrix() below.
(I don't have any experience in the matter, I was just under the impression that most other APIs seem to be designed that way...)
Good point. Thanks for the suggestion - will update.
Aryan Krishnan
Should be done now.
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
- geisserml
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
May 12, 2026, 12:12:44 PM (yesterday) May 12
to geisserml, pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang, Tom Sepez and geisserml
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
File fpdfsdk/fpdf_dict.cpp
Line 87, Patchset 14 (Latest):
FPDF_DictionaryGetMatrix(FPDF_DICTIONARY dictionary, Aryan Krishnan . unresolved
Realized this needs CL format.
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
- geisserml
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
May 12, 2026, 12:14:16 PM (yesterday) May 12
to geisserml, pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang, Tom Sepez and geisserml
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
File fpdfsdk/fpdf_dict.cpp
Realized this needs CL format.
Aryan Krishnan
Done
Related details
Attention is currently required from:
- Andy Phan
- Lei Zhang
- Tom Sepez
- geisserml
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aryan Krishnan (Gerrit)
9:19 AM (7 hours ago) 9:19 AM
to geisserml, pdfium...@luci-project-accounts.iam.gserviceaccount.com, Lei Zhang, Andy Phan, Tom Sepez, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang, Tom Sepez and geisserml
Aryan Krishnan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 15 (Latest):
Aryan Krishnan . resolved
Ping + Let me know about
1. If it is fine for us to go in this direction with a public read-only api?
2. Any design documentation or anything else of the sort needed?
3. If I should split this up (initially did not because if I add to the header then they need c++, which needs tests), although I can have the tests in a separate cl.
Reply all
Reply to author
Forward
0 new messages