Replace JBIG2_MIN_SEGMENT_SIZE with a constexpr [pdfium : main]

0 views
Skip to first unread message

Helmut Januschka (Gerrit)

unread,
Jun 1, 2026, 2:06:05 AM (4 days ago) Jun 1
to Aryan Krishnan, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Lei Zhang

Helmut Januschka added 1 comment

Commit Message
Line 7, Patchset 2:Replace JBIG2_MIN_SEGMENT_SIZE with constexpr
Aryan Krishnan . resolved

a constexpr

Helmut Januschka

Done

Aryan Krishnan

Not quite - still says "with constexpr"

Helmut Januschka

gosh, i thought gerrit takes my pushed commit msg

Open in Gerrit

Related details

Attention is currently required from:
  • Aryan Krishnan
  • Lei Zhang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ice5f22c2ffd030326a8619237cd0d591035b7a14
Gerrit-Change-Number: 148770
Gerrit-PatchSet: 4
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 06:06:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Helmut Januschka <hel...@januschka.com>
Comment-In-Reply-To: Aryan Krishnan <aryankr...@gmail.com>
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 1, 2026, 3:11:45 PM (3 days ago) Jun 1
to Helmut Januschka, Lei Zhang, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Helmut Januschka

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aryan Krishnan
  • Helmut Januschka
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ice5f22c2ffd030326a8619237cd0d591035b7a14
Gerrit-Change-Number: 148770
Gerrit-PatchSet: 4
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 19:11:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages