Replace FWL_STYLE_WGT defines with WidgetStyle enum and Mask [pdfium : main]

[Aryan Krishnan (Gerrit)]

Attention needed from Helmut Januschka

Aryan Krishnan added 2 comments

Commit Message

Line 9, Patchset 1 (Latest):Convert the base FWL widget style bitmask from preprocessor macros to a scoped enum used with fxcrt::Mask, matching the pattern established for PWL widgets in CL 145410.

Aryan Krishnan . unresolved

Line 9 seems to overflow 72 chars.

File xfa/fwl/cfwl_edit.cpp

Line 720, Patchset 1 (Latest): FWL_STYLEEXT_SCB_Vert,

Aryan Krishnan . unresolved

Can you double check if this bit has been formatted, seems a bit off that this would come to the next line when the formatted could have put it in the previous line.

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: Id77640ac2eb9013be0c9c93d975e1e8fc955faa8

Gerrit-Change-Number: 148812

Gerrit-PatchSet: 1

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>

Gerrit-CC: pdfium...@luci-project-accounts.iam.gserviceaccount.com <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Comment-Date: Sun, 31 May 2026 17:27:13 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No