Replace FWL_STYLE_WGT defines with WidgetStyle enum and Mask [pdfium : main]
Aryan Krishnan (Gerrit)
Aryan Krishnan added 2 comments![]( "Open in Gerrit")
Convert the base FWL widget style bitmask from preprocessor macros to a scoped enum used with fxcrt::Mask, matching the pattern established for PWL widgets in CL 145410.Line 9 seems to overflow 72 chars.
FWL_STYLEEXT_SCB_Vert,Can you double check if this bit has been formatted, seems a bit off that this would come to the next line when the formatted could have put it in the previous line.
Related details
- Helmut Januschka
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka added 2 comments![]( "Open in Gerrit")
Convert the base FWL widget style bitmask from preprocessor macros to a scoped enum used with fxcrt::Mask, matching the pattern established for PWL widgets in CL 145410.Line 9 seems to overflow 72 chars.
Done
Can you double check if this bit has been formatted, seems a bit off that this would come to the next line when the formatted could have put it in the previous line.
Double-checked with `git cl format` , no changes. clang-format breaks the aggregate-init list onto one element per line once the first field is `{}` rather than a bare `0`, which is why `FWL_STYLEEXT_SCB_Vert` moves to the next line.
Related details
- Aryan Krishnan
- Lei Zhang
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Lei Zhang added 3 comments![]( "Open in Gerrit")
Mask<WidgetStyle> styles_removed);All the callers pass in 0xFFFFFFFF here, so just remove this parameter and simplify the method?
kWindowTypeMask = 3L << 0,This mask should be separate from the enum, and it can be built up from the 2 values above.
properties_.styles_ &= ~styles_removed;As-is: Can call Clear() here, but see other comment about simplifying.
Related details
- Aryan Krishnan
- Helmut Januschka
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Helmut Januschka (Gerrit)
Helmut Januschka added 2 comments![]( "Open in Gerrit")
All the callers pass in 0xFFFFFFFF here, so just remove this parameter and simplify the method?
Done
This mask should be separate from the enum, and it can be built up from the 2 values above.
- Aryan Krishnan
- Lei Zhang
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
- Aryan Krishnan
- Helmut Januschka
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |