Refactor RemoveSubsettedFontPrefix() and IsStrUpper() [pdfium : main]
0 views
Skip to first unread message
Lei Zhang (Gerrit)
Feb 20, 2026, 7:43:26 PM (2 days ago) Feb 20
to Andy Phan, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Andy Phan
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andy Phan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andy Phan (Gerrit)
Feb 20, 2026, 7:54:44 PM (2 days ago) Feb 20
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Andy Phan voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Feb 20, 2026, 7:58:42 PM (2 days ago) Feb 20
to Andy Phan, Lei Zhang, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Refactor RemoveSubsettedFontPrefix() and IsStrUpper()
Refactor RemoveSubsettedFontPrefix() by performing the following:
1. Add "Maybe" prefix to the function name, since the font name may not
always have the prefix.
2. Change the pointer arg to a ref.
3. Rename subst_name to font_name. This isn't currently necessary, but
it will be moved to a different file at
https://pdfium-review.googlesource.com/c/pdfium/+/143592.
4. Use ByteString::Substr() instead of ByteString::Last().
Refactor IsStrUpper() to use a range-based for loop.
Change-Id: If31bea2e14c1609096a04835f8c0e51ae0b8a3b3
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Andy Phan <andy...@chromium.org>
Files:
- M core/fxge/cfx_fontmapper.cpp
Change size: S
Delta: 1 file changed, 10 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages