Replace PNG_ERROR_SIZE with a constexpr [pdfium : main]

0 views
Skip to first unread message

Helmut Januschka (Gerrit)

unread,
Jun 1, 2026, 2:06:26 AM (4 days ago) Jun 1
to Lei Zhang, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Lei Zhang

Helmut Januschka added 1 comment

Commit Message
Line 7, Patchset 2:Replace PNG_ERROR_SIZE with constexpr
Aryan Krishnan . resolved

a constexpr

Helmut Januschka

Done

Aryan Krishnan

Not quite yet, maybe you forgot to save? On my end it still says "With constexpr"

Helmut Januschka

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Aryan Krishnan
  • Lei Zhang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ia5f06ebc96f95a5e9a8cf65e531507cf2c97a6f5
Gerrit-Change-Number: 148790
Gerrit-PatchSet: 4
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 06:06:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Helmut Januschka <hel...@januschka.com>
Comment-In-Reply-To: Aryan Krishnan <aryankr...@gmail.com>
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Jun 1, 2026, 3:11:19 PM (3 days ago) Jun 1
to Helmut Januschka, Lei Zhang, Aryan Krishnan, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Aryan Krishnan and Helmut Januschka

Lei Zhang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aryan Krishnan
  • Helmut Januschka
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ia5f06ebc96f95a5e9a8cf65e531507cf2c97a6f5
Gerrit-Change-Number: 148790
Gerrit-PatchSet: 4
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 19:11:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages