Be stricter about CFX_StandarFont::Index. [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Jun 24, 2026, 8:38:32 PM (6 hours ago) Jun 24
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 8:48:45 PM (6 hours ago) Jun 24
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
File core/fxge/cfx_fontmapper.cpp
Line 236, Patchset 2 (Latest):
return static_cast<CFX_StandardFont::Index>(base_int);Lei Zhang . unresolved
I believe it does not go out of range, but maybe this should have a check to make sure it's casting to a valid enum value.
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jun 24, 2026, 9:08:55 PM (5 hours ago) Jun 24
to Lei Zhang, pdfium-...@googlegroups.com
Tom Sepez added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File core/fxge/cfx_fontmapper.cpp
I believe it does not go out of range, but maybe this should have a check to make sure it's casting to a valid enum value.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jun 24, 2026, 9:09:17 PM (5 hours ago) Jun 24
to Lei Zhang, pdfium-...@googlegroups.com
Tom Sepez added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 9:17:21 PM (5 hours ago) Jun 24
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
File core/fxge/cfx_fontmapper.cpp
Line 195, Patchset 3 (Latest):
int pos = base_font % 4;Lei Zhang . unresolved
Doesn't this always end up being 0 now, since IsStylableBaseFont() says the only valid values are 0, 4, and 8?
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages