Replace JBIG2_MIN_SEGMENT_SIZE with constexpr [pdfium : main]

[Aryan Krishnan (Gerrit)]

Attention needed from Helmut Januschka and Lei Zhang

Aryan Krishnan added 3 comments

Commit Message

Line 7, Patchset 2 (Latest):Replace JBIG2_MIN_SEGMENT_SIZE with constexpr

Aryan Krishnan . unresolved

a constexpr

File core/fxcodec/jbig2/jbig2_context.h

Line 29, Patchset 2 (Latest):constexpr int kJBig2MinSegmentSize = 11;

Aryan Krishnan . unresolved

Isn't really in an anonymous namespace.

Line 29, Patchset 2 (Latest):constexpr int kJBig2MinSegmentSize = 11;

Aryan Krishnan . unresolved

Also thoughts on moving this to the header?

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Lei Zhang

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: Ice5f22c2ffd030326a8619237cd0d591035b7a14

Gerrit-Change-Number: 148770

Gerrit-PatchSet: 2

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>

Gerrit-CC: pdfium...@luci-project-accounts.iam.gserviceaccount.com <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Comment-Date: Sun, 31 May 2026 14:09:06 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Aryan Krishnan (Gerrit)]

Attention needed from Helmut Januschka and Lei Zhang

Aryan Krishnan added 1 comment

File core/fxcodec/jbig2/jbig2_context.h

Line 29, Patchset 2 (Latest):constexpr int kJBig2MinSegmentSize = 11;

Aryan Krishnan . unresolved

Also thoughts on moving this to the header?

Aryan Krishnan

.cpp not header

Gerrit-Comment-Date: Sun, 31 May 2026 14:28:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Aryan Krishnan <aryankr...@gmail.com>

[Helmut Januschka (Gerrit)]

Attention needed from Aryan Krishnan and Lei Zhang

Helmut Januschka added 4 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Helmut Januschka . resolved

thank you!

Commit Message

Line 7, Patchset 2:Replace JBIG2_MIN_SEGMENT_SIZE with constexpr

Aryan Krishnan . resolved

a constexpr

Helmut Januschka

Done

File core/fxcodec/jbig2/jbig2_context.h

Line 29, Patchset 2:constexpr int kJBig2MinSegmentSize = 11;

Aryan Krishnan . resolved

Isn't really in an anonymous namespace.

Helmut Januschka

Done

Line 29, Patchset 2:constexpr int kJBig2MinSegmentSize = 11;

Aryan Krishnan . resolved

Also thoughts on moving this to the header?

Aryan Krishnan

.cpp not header

Helmut Januschka

Done

Open in Gerrit

Related details

Attention is currently required from:

• Aryan Krishnan
• Lei Zhang

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: Ice5f22c2ffd030326a8619237cd0d591035b7a14

Gerrit-Change-Number: 148770

Gerrit-PatchSet: 3

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>

Gerrit-CC: pdfium...@luci-project-accounts.iam.gserviceaccount.com <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Attention: Aryan Krishnan <aryankr...@gmail.com>

Gerrit-Comment-Date: Sun, 31 May 2026 17:09:13 +0000

[Aryan Krishnan (Gerrit)]

Attention needed from Helmut Januschka and Lei Zhang

Aryan Krishnan added 1 comment

Commit Message

Line 7, Patchset 2:Replace JBIG2_MIN_SEGMENT_SIZE with constexpr

Aryan Krishnan . unresolved

a constexpr

Helmut Januschka

Done

Aryan Krishnan

Not quite - still says "with constexpr"

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Lei Zhang

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: pdfium

Gerrit-Branch: main

Gerrit-Change-Id: Ice5f22c2ffd030326a8619237cd0d591035b7a14

Gerrit-Change-Number: 148770

Gerrit-PatchSet: 3

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Lei Zhang <the...@chromium.org>

Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>

Gerrit-CC: pdfium...@luci-project-accounts.iam.gserviceaccount.com <pdfium...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Lei Zhang <the...@chromium.org>

Gerrit-Comment-Date: Mon, 01 Jun 2026 02:35:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Helmut Januschka <hel...@januschka.com>

Comment-In-Reply-To: Aryan Krishnan <aryankr...@gmail.com>