Make CFX_Face::GetData() take data directly from CFX_Face member. [pdfium : main]

0 views

Skip to first unread message

Tom Sepez (Gerrit)

unread,

6:57 PM (2 hours ago) 6:57 PM

to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com

Tom Sepez voted and added 1 comment

Votes added by Tom Sepez

Commit-Queue

1 comment

Commit Message

Line 7, Patchset 4:Make CFX_Face::GetData() take date directly from CFX_Face member.

Lei Zhang . resolved

typo: data

Tom Sepez

ha. Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Pdfium LUCI CQ (Gerrit)

unread,

6:58 PM (2 hours ago) 6:58 PM

to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com

Pdfium LUCI CQ submitted the change

Unreviewed changes

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Make CFX_Face::GetData() take data directly from CFX_Face member.

To ease FreeType separation, do not go through the FT_FaceRec.

-- fix const correctness cascade.

Bug: 42271123

Change-Id: I2b5f0b36d504a3f687777432e953b5d176848362

Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/145032

Commit-Queue: Tom Sepez <tse...@chromium.org>

Reviewed-by: Lei Zhang <the...@chromium.org>

Files:

M core/fxge/cfx_face.cpp
M core/fxge/cfx_face.h
M core/fxge/cfx_font.h

Change size: S

Delta: 3 files changed, 6 insertions(+), 8 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Lei Zhang

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages