Abstract AGG behind RenderDeviceDriverIface:Continuation. [pdfium : main]

0 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
Feb 20, 2026, 5:52:07 PM (2 days ago) Feb 20
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ifa065518fdfe3516aaf40dcf10629074603f6b34
Gerrit-Change-Number: 143571
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Feb 2026 22:52:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Feb 20, 2026, 7:15:00 PM (2 days ago) Feb 20
to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez

Lei Zhang voted and added 2 comments

Votes added by Lei Zhang

Code-Review+1

2 comments

Commit Message
Line 7, Patchset 1 (Latest):Abstract AGG behind RenderDeviceDriverIface:Continuation.
Lei Zhang . unresolved

Double colon.

File core/fxge/renderdevicedriver_iface.h
Line 116, Patchset 1 (Latest): virtual bool ContinueDIBits(Continuation* handle,
Lei Zhang . unresolved

Rename to "continuation" here and in .cpp files.

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ifa065518fdfe3516aaf40dcf10629074603f6b34
Gerrit-Change-Number: 143571
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Sat, 21 Feb 2026 00:14:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages