Fix length botch in CPDF_StreamContentParser::FindColorSpace() [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Apr 7, 2026, 7:33:27 PM (4 days ago) Apr 7
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Apr 7, 2026, 7:43:00 PM (4 days ago) Apr 7
to Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Tom Sepez voted Commit-Queue+0![]( "Open in Gerrit")
| Commit-Queue | +0 |
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Apr 7, 2026, 7:44:29 PM (4 days ago) Apr 7
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Apr 8, 2026, 12:41:13 PM (3 days ago) Apr 8
to Pdfium LUCI CQ, Lei Zhang, pdfium-...@googlegroups.com
Tom Sepez voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Apr 8, 2026, 12:48:37 PM (3 days ago) Apr 8
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Fix length botch in CPDF_StreamContentParser::FindColorSpace()
`name` starts with the 6-character prefix "Device" per if-statement, but
`Substr(7)` skips the first 7 characters. For "DeviceCMYK" it results in
"DefaultMYK". The intent here was clearly to look up "DefaultCMYK".
Flaw detected by Gemini review of previous patch.
Change-Id: I103bbfad65cf6262f64b2df94cf0f3a4110b7b7a
Commit-Queue: Tom Sepez <tse...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Files:
- M core/fpdfapi/page/cpdf_streamcontentparser.cpp
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages