Ban abseil variant.h and utility.h libraries in pdfium [pdfium : main]
Lei Zhang (Gerrit)
Lei Zhang added 2 comments![]( "Open in Gerrit")
https://source.chromium.org/chromium/chromium/src/+/main:third_party/abseil-cpp/absl/types/variant.h;l=33-44;drc=b3defd119a78557e3d5d10f0683c2380b635c67eI feel better about https://chromium.googlesource.com/chromium/src/+/b3defd119a78557e3d5d10f0683c2380b635c67e/third_party/abseil-cpp/absl/types/variant.h#33 being a semi-permanent link, though it can't highlight a range of lines.
(Not sure this is needed, given the ban in DEPS. Note that nothing else from abseil is banned by this file.
Related details
- Victor Vianna
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Vianna (Gerrit)
Victor Vianna added 2 comments![]( "Open in Gerrit")
I feel better about https://chromium.googlesource.com/chromium/src/+/b3defd119a78557e3d5d10f0683c2380b635c67e/third_party/abseil-cpp/absl/types/variant.h#33 being a semi-permanent link, though it can't highlight a range of lines.
Not sure this is needed, given the ban in DEPS. Note that nothing else from abseil is banned by this file.
The header can still be transitively included despite DEPS, so this makes a difference. We did it for chromium/src/PRESUBMIT.py
Related details
- Lei Zhang
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
Victor ViannaNot sure this is needed, given the ban in DEPS. Note that nothing else from abseil is banned by this file.
The header can still be transitively included despite DEPS, so this makes a difference. We did it for chromium/src/PRESUBMIT.py
- Victor Vianna
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Vianna (Gerrit)
Victor Vianna voted Commit-Queue+2![]( "Open in Gerrit")
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Ban abseil variant.h and utility.h libraries in pdfium
These are just delegating to std now. All usages outside of
third_party were migrated to use std directly.
https://chromium.googlesource.com/chromium/src/+/b3defd119a78557e3d5d10f0683c2380b635c67e/third_party/abseil-cpp/absl/types/variant.h#33
https://chromium.googlesource.com/chromium/src/+/b3defd119a78557e3d5d10f0683c2380b635c67e/third_party/abseil-cpp/absl/utility/utility.h#35
- M DEPS
- M PRESUBMIT.py
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |