Move standard font data and accessors to CFX_StandardFont [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Jun 24, 2026, 6:23:36 PM (11 hours ago) Jun 24
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 24, 2026, 6:27:59 PM (11 hours ago) Jun 24
to Tom Sepez, Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Jun 24, 2026, 6:34:51 PM (11 hours ago) Jun 24
to Lei Zhang, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Tom Sepez voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 24, 2026, 7:12:47 PM (11 hours ago) Jun 24
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
pdfium...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: core/fxge/cfx_fontmgr.cpp
Insertions: 0, Deletions: 1.
@@ -16,7 +16,6 @@
#include "core/fxge/cfx_font.h"
#include "core/fxge/cfx_fontmapper.h"
#include "core/fxge/cfx_glyphcache.h"
-#include "core/fxge/cfx_standardfont.h"
#include "core/fxge/fx_font.h"
#include "core/fxge/systemfontinfo_iface.h"
```
```
The name of the file: core/fxge/cfx_fontmapper.cpp
Insertions: 1, Deletions: 2.
@@ -13,6 +13,7 @@
#include <utility>
#include "build/build_config.h"
+#include "core/fxcrt/cfx_read_only_span_stream.h"
#include "core/fxcrt/check_op.h"
#include "core/fxcrt/containers/adapters.h"
#include "core/fxcrt/containers/contains.h"
@@ -30,8 +31,6 @@
namespace {
-
-
struct AltFontFamily {
const char* font_name_; // Raw, POD struct.
const char* font_family_; // Raw, POD struct.
```
Change information
Commit message:
Move standard font data and accessors to CFX_StandardFont
Move the Foxit standard font data arrays (kFoxitFonts,
kGenericSansFont, kGenericSerifFont) from CFX_FontMgr to
CFX_StandardFont.
TAG=agy
CONV=439b75d1-0eaa-431e-88db-03db44aed371
Change-Id: I030ddf21aa7e48186ae77c327c3335eb4f65edac
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Files:
- M core/fxge/cfx_fontmapper.cpp
- M core/fxge/cfx_fontmgr.cpp
- M core/fxge/cfx_fontmgr.h
- M core/fxge/cfx_standardfont.cpp
- M core/fxge/cfx_standardfont.h
Change size: M
Delta: 5 files changed, 47 insertions(+), 51 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages