Add an embedder test for text spacing being lost when saving [pdfium : main]
0 views
Skip to first unread message
Lei Zhang (Gerrit)
Mar 13, 2026, 5:48:22 PM (4 days ago) Mar 13
to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan
Lei Zhang voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Andy Phan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andy Phan (Gerrit)
Mar 13, 2026, 6:43:46 PM (4 days ago) Mar 13
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
Andy Phan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andy Phan
| Code-Review | +1 |
1 comment
File testing/resources/bug_410996566.in
Line 45, Patchset 4 (Latest):
[(H) -100 (e) (l) -200 (l) (o) 150 (,) ( ) (worl) (d) -500 (!)] TJAndy Phan . resolved
Negative numbers move the text right? Interesting...
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Mar 13, 2026, 6:45:21 PM (4 days ago) Mar 13
to Lei Zhang, Andy Phan, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Commit-Queue | +2 |
1 comment
File testing/resources/bug_410996566.in
Line 45, Patchset 4 (Latest):
[(H) -100 (e) (l) -200 (l) (o) 150 (,) ( ) (worl) (d) -500 (!)] TJAndy Phan . resolved
Negative numbers move the text right? Interesting...
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Mar 13, 2026, 6:46:25 PM (4 days ago) Mar 13
to Lei Zhang, Andy Phan, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add an embedder test for text spacing being lost when saving
Add a test to show modifying PDF pages where a text object that uses the
TJ operator to specify horizontal spacing renders correctly in memory,
but the text object loses its spacing when saved.
Bug: 410996566
Change-Id: I702c9845557bcd1b615abb972fe68edaf45ae1a2
Commit-Queue: Lei Zhang <the...@chromium.org>
Reviewed-by: Andy Phan <andy...@chromium.org>
Files:
- M fpdfsdk/fpdf_edit_embeddertest.cpp
- A testing/resources/bug_410996566.in
- A testing/resources/bug_410996566.pdf
- A testing/resources/embedder_tests/bug_410996566.png
- A testing/resources/embedder_tests/bug_410996566_agg_mac.png
- A testing/resources/embedder_tests/bug_410996566_skia.png
- A testing/resources/embedder_tests/bug_410996566_skia_mac.png
- A testing/resources/embedder_tests/bug_410996566_skia_win.png
- A testing/resources/embedder_tests/bug_410996566_skia_x86.png
- A testing/resources/embedder_tests/bug_410996566_wrong_spacing.png
- A testing/resources/embedder_tests/bug_410996566_wrong_spacing_agg_mac.png
- A testing/resources/embedder_tests/bug_410996566_wrong_spacing_skia.png
- A testing/resources/embedder_tests/bug_410996566_wrong_spacing_skia_mac.png
- A testing/resources/embedder_tests/bug_410996566_wrong_spacing_skia_win.png
- A testing/resources/embedder_tests/bug_410996566_wrong_spacing_skia_x86.png
Change size: M
Delta: 15 files changed, 148 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andy Phan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages