Replace form filler style defines with PStyles struct [pdfium : main]

0 views
Skip to first unread message

Aryan Krishnan (Gerrit)

unread,
Mar 26, 2026, 2:47:11 PMMar 26
to Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez

Aryan Krishnan voted and added 1 comment

Votes added by Aryan Krishnan

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Aryan Krishnan . resolved

Hi, removed the defines here as well, this also involved some amount of refactoring and it was tough to remove only some of the defines for each CL and hence had to resort to removing all of them at once. Let me know if there is a better way to do this than this big struct. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Lei Zhang
  • Tom Sepez
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ie2dfde5cd2227a95982d86094ac552bc5f4cf32b
Gerrit-Change-Number: 145410
Gerrit-PatchSet: 8
Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Thu, 26 Mar 2026 18:47:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Aryan Krishnan (Gerrit)

unread,
Mar 26, 2026, 2:48:47 PMMar 26
to Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez

Aryan Krishnan added 1 comment

File fpdfsdk/pwl/cpwl_wnd.h
Line 127, Patchset 8 (Latest): CreateParams* GetCreationParams() { return &creation_params_; }
Aryan Krishnan . unresolved

@the...@chromium.org, what do you think about individual functions to see if each flag exists, would make this CL far larger, but would allow us to put this back in private.

3 Options here:

A. Update this CL to do that
B. Follow up CL
C. Leave it

WDYT?

Would say B IMO, don't want to make this any larger.

Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Lei Zhang
  • Tom Sepez
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: pdfium
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie2dfde5cd2227a95982d86094ac552bc5f4cf32b
    Gerrit-Change-Number: 145410
    Gerrit-PatchSet: 8
    Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
    Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Lei Zhang <the...@chromium.org>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Andy Phan <andy...@chromium.org>
    Gerrit-Comment-Date: Thu, 26 Mar 2026 18:48:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Aryan Krishnan (Gerrit)

    unread,
    Apr 7, 2026, 1:35:37 PM (4 days ago) Apr 7
    to Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
    Attention needed from Andy Phan, Lei Zhang and Tom Sepez

    Aryan Krishnan added 1 comment

    File fpdfsdk/pwl/cpwl_wnd.h
    Line 127, Patchset 8 (Latest): CreateParams* GetCreationParams() { return &creation_params_; }
    Aryan Krishnan . resolved

    @the...@chromium.org, what do you think about individual functions to see if each flag exists, would make this CL far larger, but would allow us to put this back in private.

    3 Options here:

    A. Update this CL to do that
    B. Follow up CL
    C. Leave it

    WDYT?

    Would say B IMO, don't want to make this any larger.

    Aryan Krishnan

    Marked as resolved, its for a future CL anyway

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andy Phan
    • Lei Zhang
    • Tom Sepez
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: pdfium
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie2dfde5cd2227a95982d86094ac552bc5f4cf32b
      Gerrit-Change-Number: 145410
      Gerrit-PatchSet: 8
      Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
      Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
      Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
      Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
      Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
      Gerrit-Attention: Lei Zhang <the...@chromium.org>
      Gerrit-Attention: Tom Sepez <tse...@chromium.org>
      Gerrit-Attention: Andy Phan <andy...@chromium.org>
      Gerrit-Comment-Date: Tue, 07 Apr 2026 17:35:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Aryan Krishnan <aryankr...@gmail.com>
      unsatisfied_requirement
      open
      diffy

      Aryan Krishnan (Gerrit)

      unread,
      Apr 8, 2026, 1:29:21 PM (3 days ago) Apr 8
      to Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
      Attention needed from Andy Phan, Lei Zhang and Tom Sepez

      Aryan Krishnan added 1 comment

      File fpdfsdk/pwl/cpwl_wnd.h
      Line 43, Patchset 8 (Latest): bool win_no_refresh_clip = false;
      Aryan Krishnan . unresolved

      Probably fxcrt::mask this as well. WIP for now.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andy Phan
      • Lei Zhang
      • Tom Sepez
      Submit Requirements:
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: pdfium
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie2dfde5cd2227a95982d86094ac552bc5f4cf32b
        Gerrit-Change-Number: 145410
        Gerrit-PatchSet: 8
        Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
        Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
        Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
        Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
        Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
        Gerrit-Attention: Lei Zhang <the...@chromium.org>
        Gerrit-Attention: Tom Sepez <tse...@chromium.org>
        Gerrit-Attention: Andy Phan <andy...@chromium.org>
        Gerrit-Comment-Date: Wed, 08 Apr 2026 17:29:16 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages