Refine text extraction logic for zero-width characters [pdfium : main]

0 views
Skip to first unread message

Aryan Krishnan (Gerrit)

unread,
Mar 12, 2026, 9:56:06 AM (5 days ago) Mar 12
to Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, rubber-...@appspot.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang, Tom Sepez and rubber-...@appspot.gserviceaccount.com

Aryan Krishnan added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Aryan Krishnan . resolved

Hi guys, added this which should fix the previous issues with the previous CL, there may be a few more things for us to look at (especially with the new IsZeroWidthSpace updates). Removed the boilerplate in the commit message as well as it was overly long, thanks!

Open in Gerrit

Related details

Attention is currently required from:
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I3afe6e9b6972b750fbd14c7433f4b8cc41d4ef80
Gerrit-Change-Number: 144690
Gerrit-PatchSet: 6
Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 13:56:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Mar 12, 2026, 9:57:17 AM (5 days ago) Mar 12
to Aryan Krishnan, Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Aryan Krishnan, Lei Zhang and Tom Sepez

Message from rubber-...@appspot.gserviceaccount.com

Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.

Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Aryan Krishnan
  • Lei Zhang
  • Tom Sepez
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I3afe6e9b6972b750fbd14c7433f4b8cc41d4ef80
Gerrit-Change-Number: 144690
Gerrit-PatchSet: 6
Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 13:57:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Aryan Krishnan (Gerrit)

unread,
Mar 16, 2026, 9:48:01 PM (23 hours ago) Mar 16
to Pdfium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, pdfium-...@googlegroups.com
Attention needed from Andy Phan, Lei Zhang and Tom Sepez

Aryan Krishnan added 1 comment

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Aryan Krishnan . resolved

Following up.

Open in Gerrit

Related details

Attention is currently required from:
  • Andy Phan
  • Lei Zhang
  • Tom Sepez
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: I3afe6e9b6972b750fbd14c7433f4b8cc41d4ef80
Gerrit-Change-Number: 144690
Gerrit-PatchSet: 11
Gerrit-Owner: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Andy Phan <andy...@chromium.org>
Gerrit-Reviewer: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Andy Phan <andy...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Mar 2026 01:47:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages