Early return for zero dest_len in WeightTable::CalculateWeights(). [pdfium : master]

Tom Sepez (Gerrit)

unread,

Jun 16, 2021, 9:13:00 PM6/16/21

to Lei Zhang, pdfium-...@googlegroups.com

Attention is currently required from: Lei Zhang.

View Change

1 comment:

File core/fxge/dib/cstretchengine.cpp:
- Patch Set #3, Line 90: dest_len;
  i.e. here,

To view, visit change 82171. To unsubscribe, or for help writing mail filters, visit settings.

Lei Zhang (Gerrit)

unread,

Jun 16, 2021, 11:41:18 PM6/16/21

to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com

Attention is currently required from: Tom Sepez.

Patch set 4:Code-Review +1

View Change

To view, visit change 82171. To unsubscribe, or for help writing mail filters, visit settings.

Tom Sepez (Gerrit)

unread,

Jun 17, 2021, 2:18:45 PM6/17/21

to Lei Zhang, pdfium-...@googlegroups.com

Attention is currently required from: Tom Sepez.

Patch set 5:Commit-Queue +2

View Change

To view, visit change 82171. To unsubscribe, or for help writing mail filters, visit settings.

Pdfium LUCI CQ (Gerrit)

unread,

Jun 17, 2021, 3:30:02 PM6/17/21

to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com

Pdfium LUCI CQ submitted this change.

View Change

Approvals:
  Lei Zhang: Looks good to me
  Tom Sepez: Commit

Early return for zero dest_len in WeightTable::CalculateWeights().

Avoid a possible floating div-by-zero later on and return a nice empty
table for this case.

Change-Id: Ib8bdc732f778e1368a32cb0e60545b443d3df1c6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/82171
Commit-Queue: Tom Sepez <tse...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
---
M core/fxge/dib/cstretchengine.cpp
M core/fxge/dib/cstretchengine_unittest.cpp
2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/core/fxge/dib/cstretchengine.cpp b/core/fxge/dib/cstretchengine.cpp
index 5b2ff3b..ade1c81 100644
--- a/core/fxge/dib/cstretchengine.cpp
+++ b/core/fxge/dib/cstretchengine.cpp
@@ -67,6 +67,9 @@
   m_ItemSizeBytes = 0;
   m_WeightTablesSizeBytes = 0;
   m_WeightTables.clear();
+  if (dest_len == 0)
+    return true;
+
   if (dest_min > dest_max)
     return false;
 
diff --git a/core/fxge/dib/cstretchengine_unittest.cpp b/core/fxge/dib/cstretchengine_unittest.cpp
index 6db7667..2053155 100644
--- a/core/fxge/dib/cstretchengine_unittest.cpp
+++ b/core/fxge/dib/cstretchengine_unittest.cpp
@@ -135,3 +135,9 @@
   CStretchEngine::WeightTable table;
   ASSERT_TRUE(table.CalculateWeights(100, 0, 100, 0, 0, 0, options));
 }
+
+TEST(CStretchEngine, ZeroLengthDest) {
+  FXDIB_ResampleOptions options;
+  CStretchEngine::WeightTable table;
+  ASSERT_TRUE(table.CalculateWeights(0, 0, 0, 100, 0, 100, options));
+}

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 82171. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward