Replace FXFONT_USEEXTERNATTR define with kFontUseExternAttr constexpr [pdfium : main]

0 views
Skip to first unread message

Aryan Krishnan (Gerrit)

unread,
May 31, 2026, 1:30:53 PM (4 days ago) May 31
to Helmut Januschka, pdfium...@luci-project-accounts.iam.gserviceaccount.com, pdfium-...@googlegroups.com
Attention needed from Helmut Januschka

Aryan Krishnan added 2 comments

Commit Message
Line 7, Patchset 1 (Latest):Replace FXFONT_USEEXTERNATTR define with kFontUseExternAttr constexpr
Aryan Krishnan . unresolved

Nit:
```suggestion
Replace FXFONT_USEEXTERNATTR define with constexpr kFontUseExternAttr
```

Line 9, Patchset 1 (Latest):Move the "use external attributes" font flag from a preprocessor define into namespace pdfium as an inline constexpr uint32_t, alongside the existing FontStyle/FontWeight/FontPitchFamily enums.
Aryan Krishnan . unresolved

Wrap Line 9

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pdfium
Gerrit-Branch: main
Gerrit-Change-Id: Ia359b2832e8de076035afb631779527c51edb240
Gerrit-Change-Number: 148834
Gerrit-PatchSet: 1
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-CC: Aryan Krishnan <aryankr...@gmail.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Comment-Date: Sun, 31 May 2026 17:30:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages