Always parse fonts with skia when checks requested. [pdfium : main]
Tom Sepez (Gerrit)
Tom Sepez removed a vote from this change![]( "Open in Gerrit")
Removed Code-Review+1 by Lei Zhang <the...@chromium.org>
Related details
- Lei Zhang
- Tom Sepez
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Tom Sepez added 1 comment![]( "Open in Gerrit")
#if defined(PDF_ENABLE_FONTATIONS)Lei ZhangNOTE: would like to do this for PDF_USE_SKIA, but profiling embedder_tests shows that only about 40% of fonts are loaded this way later on. Too much?
Tom SepezCan this be guarded by a run-time check rather than compile-time?
Lei ZhangProbably, but yet another initialization parameter. I'll leave it for fontations at the moment.
Tom SepezIsn't it just a `CFX_FontMgr::font_backend_` query, exposed via CFX_GEModule?
Lei ZhangI'm cheating. I actually want to check that normal skia returns the same things in a follow-on CL. Suggestions?
Tom SepezMaybe write a TODO or have some other reminder to eventually stop cheating?
Does this make you happier?
Related details
- Lei Zhang
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
#if defined(PDF_ENABLE_FONTATIONS)Lei ZhangNOTE: would like to do this for PDF_USE_SKIA, but profiling embedder_tests shows that only about 40% of fonts are loaded this way later on. Too much?
Tom SepezCan this be guarded by a run-time check rather than compile-time?
Lei ZhangProbably, but yet another initialization parameter. I'll leave it for fontations at the moment.
Tom SepezIsn't it just a `CFX_FontMgr::font_backend_` query, exposed via CFX_GEModule?
Lei ZhangI'm cheating. I actually want to check that normal skia returns the same things in a follow-on CL. Suggestions?
Tom SepezMaybe write a TODO or have some other reminder to eventually stop cheating?
Does this make you happier?
- Tom Sepez
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Tom Sepez voted Commit-Queue+2![]( "Open in Gerrit")
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Pdfium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Always parse fonts with skia when checks requested.
Simplify extracting information from Skia in subsequent CLs.
- M core/fxge/cfx_face.cpp
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |