Remove CFX_DIBitmap::TakeOver(). [pdfium : main]
0 views
Skip to first unread message
Tom Sepez (Gerrit)
Feb 19, 2026, 7:18:25 PM (3 days ago) Feb 19
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Feb 19, 2026, 7:24:06 PM (3 days ago) Feb 19
to Tom Sepez, Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Attention needed from Tom Sepez
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
File core/fxge/cfx_glyphbitmap.cpp
Line 12, Patchset 2 (Latest):
: left_(left), top_(top), bitmap_(pdfium::MakeRetain<CFX_DIBitmap>()) {}Lei Zhang . unresolved
Maybe delegate to the new ctor.
Related details
Attention is currently required from:
- Tom Sepez
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Feb 19, 2026, 7:27:39 PM (3 days ago) Feb 19
to Lei Zhang, Pdfium LUCI CQ, pdfium-...@googlegroups.com
Tom Sepez voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Sepez
| Commit-Queue | +2 |
1 comment
File core/fxge/cfx_glyphbitmap.cpp
Line 12, Patchset 2:
: left_(left), top_(top), bitmap_(pdfium::MakeRetain<CFX_DIBitmap>()) {}Lei Zhang . resolved
Maybe delegate to the new ctor.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Pdfium LUCI CQ (Gerrit)
Feb 19, 2026, 8:42:20 PM (3 days ago) Feb 19
to Tom Sepez, Lei Zhang, pdfium-...@googlegroups.com
Pdfium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: core/fxge/cfx_glyphbitmap.cpp
Insertions: 1, Deletions: 1.
@@ -9,7 +9,7 @@
#include "core/fxge/dib/cfx_dibitmap.h"
CFX_GlyphBitmap::CFX_GlyphBitmap(int left, int top)
- : left_(left), top_(top), bitmap_(pdfium::MakeRetain<CFX_DIBitmap>()) {}
+ : CFX_GlyphBitmap(left, top, pdfium::MakeRetain<CFX_DIBitmap>()) {}
CFX_GlyphBitmap::CFX_GlyphBitmap(int left,
int top,
```
Change information
Commit message:
Remove CFX_DIBitmap::TakeOver().
No need to copy when the only caller has an unique original. Pass it
to a new CFX_GlyphBitmap constructor instead.
Change-Id: Ia35947c482ac489a2a15a41b3391ab145d9b05c4
Commit-Queue: Tom Sepez <tse...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Files:
- M core/fpdfapi/render/cpdf_type3cache.cpp
- M core/fxge/cfx_glyphbitmap.cpp
- M core/fxge/cfx_glyphbitmap.h
- M core/fxge/dib/cfx_dibitmap.cpp
- M core/fxge/dib/cfx_dibitmap.h
Change size: S
Delta: 5 files changed, 10 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages